Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Quadratic Cloud Files V1 #530

Merged
merged 192 commits into from
Aug 17, 2023
Merged

feat: Quadratic Cloud Files V1 #530

merged 192 commits into from
Aug 17, 2023

Conversation

jimniels
Copy link
Collaborator

@jimniels jimniels commented May 22, 2023

Because this PR is such a fundamental change, everything about the app should be tested, including:

  • Authentication flow (log in, log out)
  • Authenticated & non-authenticated users only have access to appropriate routes
  • Cloud files migration
  • Cross browser, including mobile/tablet
  • TODO list of things that we should ensure we test

Known outstanding issues:

  • Sync/debounce/cancel file sync requests
  • Refactor how analytics load so we can use them in loaders fix: analytics #637
  • Update the instructions for how people can run the app locally, e.g. env variables, client and server tasks, etc.
  • Back button after logging in (won't fix)
  • Support "open in new tab" for file list items (e.g. example file)
  • Comment out light/dark mode toggle
  • Consider removing rate limiting (delete lots of files will trigger it)
  • Cross browser testing (mobile too)
  • Fix TODOs in the current PR
  • Docker for development (David)
  • Make all routes (not defined in the root routes component) as string constants for use elsewhere in the app
  • Social share/open graph meta info in index.html feat: social share meta/image #636

David - Review

  • review the code
  • review files and upgrade path
  • test the upgrade flow

Deployment Review

  • migrate staging (test prisma migration flow) (edi

@vercel
Copy link

vercel bot commented May 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
quadratic ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 17, 2023 5:40pm

@jimniels jimniels temporarily deployed to quadratic-staging May 25, 2023 01:47 Inactive
@jimniels jimniels temporarily deployed to quadratic-staging May 25, 2023 01:56 Inactive
@jimniels jimniels temporarily deployed to quadratic-staging May 25, 2023 02:08 Inactive
@jimniels jimniels reopened this Jul 7, 2023
@jimniels jimniels temporarily deployed to quadratic-api-dev-pr-530 August 16, 2023 22:15 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-530 August 16, 2023 22:32 Inactive
@jimniels jimniels temporarily deployed to quadratic-api-dev-pr-530 August 16, 2023 22:34 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-530 August 16, 2023 23:44 Inactive
@jimniels jimniels temporarily deployed to quadratic-api-dev-pr-530 August 17, 2023 16:44 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-530 August 17, 2023 16:53 Inactive
@jimniels jimniels temporarily deployed to quadratic-api-dev-pr-530 August 17, 2023 17:12 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-staging August 17, 2023 17:24 Inactive
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-645 August 17, 2023 17:38 Inactive
@jimniels jimniels merged commit 2d8e55f into main Aug 17, 2023
12 checks passed
@jimniels jimniels deleted the share-file branch August 17, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants