fix: anon users can't double click to edit #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jimniels
commented
Sep 15, 2023
| }); | ||
| } | ||
| event.preventDefault(); | ||
| }; |
There was a problem hiding this comment.
I found this file cause I thought it might be where the double click logic was. But nothing was happening. Then I realized onDoubleClickCanvas doesn't get imported anywhere so it doesn't look like this file gets used — so i deleted it.
davidfig
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the bug where anonymous users were able to double click a cell and edit it (though changes weren't saved).
It also fixes a bug where double-click/ENTER weren't working for formula/python cells. Now, if you're an anonymous user and you double-click/ENTER on a python cell, the code editor will still open (though you can't edit it).