Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed sheet mutli-sheet rendering bug #920

Merged
merged 4 commits into from
Dec 7, 2023
Merged

Conversation

davidfig
Copy link
Collaborator

@davidfig davidfig commented Dec 7, 2023

  • fixes rendering of charts when on different sheets when reloading the app
  • improved flicker of charts when switching between sheets
  • bug: when resizing a column that would move a chart. the chart doesn't move until the page is reloaded

Fixes #919

Copy link

vercel bot commented Dec 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quadratic ✅ Ready (Inspect) Visit Preview Dec 7, 2023 5:26pm

@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-920 December 7, 2023 13:21 Inactive
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5853d3d) 88.52% compared to head (a896ea8) 88.52%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #920   +/-   ##
=======================================
  Coverage   88.52%   88.52%           
=======================================
  Files          99       99           
  Lines       17765    17765           
=======================================
  Hits        15726    15726           
  Misses       2039     2039           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-920 December 7, 2023 17:21 Inactive
@davidkircos davidkircos merged commit 63503e6 into main Dec 7, 2023
9 checks passed
@davidkircos davidkircos deleted the fix-charts-sheet-placement branch December 7, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Charts get written to all sheets when reloading
2 participants