-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mp pubsub #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ddimaria
commented
Jan 4, 2024
•
edited
Loading
edited
- Add Redis within docker-compose
- Add pubsub trait to rust-shared
- Implement Redis PubSub in rust-shared (new, connect, subscribe, publish, get_message)
- Implement Redis Streams in rust-shared (new, connect, subscribe, publish, get_message)
- Make the file service a stand-alone service
- Add a healthcheck to the file service and multiplayer
- Every X seconds, display stats in the logs
- Handle pubsub connection loss with reconnects
- Check quadratic-api for new permissions
- Enforce file permissions
- 90% coverage
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## a-team #961 +/- ##
==========================================
+ Coverage 89.70% 89.77% +0.07%
==========================================
Files 122 124 +2
Lines 20639 20971 +332
==========================================
+ Hits 18514 18827 +313
- Misses 2125 2144 +19 ☔ View full report in Codecov by Sentry. |
72 tasks
…in quadratic-multiplayer
davidfig
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.