Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mp pubsub #961

Merged
merged 50 commits into from
Jan 16, 2024
Merged

Mp pubsub #961

merged 50 commits into from
Jan 16, 2024

Conversation

ddimaria
Copy link
Collaborator

@ddimaria ddimaria commented Jan 4, 2024

  • Add Redis within docker-compose
  • Add pubsub trait to rust-shared
  • Implement Redis PubSub in rust-shared (new, connect, subscribe, publish, get_message)
  • Implement Redis Streams in rust-shared (new, connect, subscribe, publish, get_message)
  • Make the file service a stand-alone service
  • Add a healthcheck to the file service and multiplayer
  • Every X seconds, display stats in the logs
  • Handle pubsub connection loss with reconnects
  • Check quadratic-api for new permissions
  • Enforce file permissions
  • 90% coverage

Copy link

vercel bot commented Jan 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quadratic ❌ Failed (Inspect) Jan 16, 2024 5:40pm

@ddimaria ddimaria changed the base branch from main to mp-naive-file-service January 4, 2024 18:54
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-961 January 4, 2024 18:54 Inactive
Base automatically changed from mp-naive-file-service to a-team January 4, 2024 19:15
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-961 January 4, 2024 19:43 Inactive
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 31 lines in your changes are missing coverage. Please review.

Comparison is base (23247e0) 89.70% compared to head (77de9a8) 89.77%.
Report is 83 commits behind head on a-team.

Files Patch % Lines
...re/src/controller/execution/receive_multiplayer.rs 83.33% 17 Missing ⚠️
...roller/active_transactions/unsaved_transactions.rs 85.71% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           a-team     #961      +/-   ##
==========================================
+ Coverage   89.70%   89.77%   +0.07%     
==========================================
  Files         122      124       +2     
  Lines       20639    20971     +332     
==========================================
+ Hits        18514    18827     +313     
- Misses       2125     2144      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidkircos davidkircos mentioned this pull request Jan 5, 2024
72 tasks
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-961 January 5, 2024 19:23 Inactive
@ddimaria ddimaria marked this pull request as ready for review January 16, 2024 16:39
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-961 January 16, 2024 17:33 Inactive
@ddimaria ddimaria merged commit e645a77 into a-team Jan 16, 2024
5 of 11 checks passed
@ddimaria ddimaria deleted the mp-pubsub branch January 16, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants