Update electron #138
Merged
Update electron #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ficristo
force-pushed
the
feature/electron-update
branch
from
a1b5f0c
to
b278c52
Compare
ficristo
force-pushed
the
feature/electron-update
branch
3 times, most recently
from
2f3be53
to
580a55d
Compare
ficristo
force-pushed
the
feature/electron-update
branch
from
bdafa47
to
3d8c215
Compare
Closed
ficristo
force-pushed
the
feature/electron-update
branch
from
fc5303e
to
45c9209
Compare
|
To upgrade to latest electron need to wait for electron/electron#16224 |
ficristo
force-pushed
the
feature/electron-update
branch
2 times, most recently
from
7135c37
to
868bb28
Compare
MacOS build fails because of electron-userland/electron-builder#3385
ficristo
force-pushed
the
feature/electron-update
branch
from
37b1053
to
82f32d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also update electron-rebuild to 1.8.2.Make sure electron-rebuild pick a more up do date version of node-abi for electron >= 2 compatibilityUpdate electron to 5.0.0
MacOS build fails because of electron-userland/electron-builder#3385