Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

null version detected for bower dependencies #13

Closed
amk221 opened this issue Dec 1, 2014 · 8 comments
Closed

null version detected for bower dependencies #13

amk221 opened this issue Dec 1, 2014 · 8 comments

Comments

@amk221
Copy link

amk221 commented Dec 1, 2014

When pulling a bower dependancy from a git url like: git://github.com/amk221/my-thing.git _#master_
the dependancy is determined to be 'not installed' (therefore builds fail).
It works without the #tag

@stefanpenner
Copy link
Collaborator

This also seems to be a problem if the destination repo has no bower.json file. Such as: https://github.com/furf/jquery-ui-touch-punch

I suspect if the folder exists, but no bower.json file exists we should likely just best-effort assume all is satisfied.

@quaertym
Copy link
Owner

quaertym commented Dec 2, 2014

I was not sure how to handle this. @stefanpenner I will try your suggestion.

@stefanpenner
Copy link
Collaborator

@quaertym Ya, I am not quite sure the best way either, maybe someone else has a better idea.

For reference my solution/workaround was to merely "vendor" this dependency and commit it to my project manually.

@quaertym
Copy link
Owner

quaertym commented Dec 2, 2014

@stefanpenner 👍 for vendor approach but I think many users are not aware of it. We should cover this use case anyway. There is also a problem with static files that bower manages see this pr #12.

@mixonic
Copy link
Contributor

mixonic commented Dec 2, 2014

Yeah, this bit us as well today. Ugly and more than a bit perplexing.

@soulcutter
Copy link

I ran into this with an http dependency

    "sinon": "http://sinonjs.org/releases/sinon-1.12.1.js"

Not sure if it's relevant, but I did notice that bower_components/sinon does have a .bower.json file in there - is that artifact usable in lieu of a bower.json file?

@shaunc
Copy link

shaunc commented Dec 7, 2014

I ran into the same "sinon" issue ... and also now have a problem with antiscroll as installed by ember-cli-ember-table. Could someone explain the "vendor" workaround? I have got things working temporarily by simply deleting the reference in bower.json after I install, but this is obviously just a temporary patch for development.

@rupurt
Copy link

rupurt commented Sep 24, 2015

@amk221 @stefanpenner thanks for the suggestion. Is there any tooling support for vendoring a dependency or do I just need to put it in the my_ember_app/vendor directory manually?

I've got it working manually but it would be nice if there was a command I could run to update the package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants