semver doesn't recognise a version of "*" #18

simonexmachina · 2015-01-13T04:57:59Z

If a dependency has a version of "*" then the dependency checker throws an exception, and doesn't indicate where the dependency is coming from.

Invalid Version: *
TypeError: Invalid Version: *
    at new SemVer (terminal/node_modules/ember-cli-dependency-checker/node_modules/semver/semver.js:273:11)
    at Range.test (terminal/node_modules/ember-cli-dependency-checker/node_modules/semver/semver.js:998:15)
    at Function.satisfies (terminal/node_modules/ember-cli-dependency-checker/node_modules/semver/semver.js:1047:16)
    at Package.updateRequired (terminal/node_modules/ember-cli-dependency-checker/lib/package.js:35:18)
    at new Package (terminal/node_modules/ember-cli-dependency-checker/lib/package.js:7:27)
    at EmberCLIDependencyChecker.<anonymous> (terminal/node_modules/ember-cli-dependency-checker/lib/dependency-checker.js:85:12)
    at Array.map (native)
    at EmberCLIDependencyChecker.readBowerDependencies (terminal/node_modules/ember-cli-dependency-checker/lib/dependency-checker.js:82:36)
    at EmberCLIDependencyChecker.checkDependencies (terminal/node_modules/ember-cli-dependency-checker/lib/dependency-checker.js:28:24)
    at new EmberCLIDependencyChecker (terminal/node_modules/ember-cli-dependency-checker/lib/dependency-checker.js:19:8)

The text was updated successfully, but these errors were encountered:

cmosguy · 2015-01-14T02:39:11Z

What do you do when you get this?

simonexmachina · 2015-01-14T02:41:13Z

To make this happen? I'll not sure what package causes it, but presumably
there a dependency somewhere that refers to a version of "*", which means "
any version ".

On Wed, 14 Jan 2015 13:39 Adam Klein notifications@github.com wrote:

What do you do when you get this?

—
Reply to this email directly or view it on GitHub
#18 (comment)
.

cmosguy · 2015-01-14T02:42:25Z

@aexmachina this stinks, I am removing this. why did someone put this in the ember-cli 0.1.7 and not test this?

simonexmachina · 2015-01-14T02:45:00Z

It's a useful module, but yes could have done with more testing.

On Wed, 14 Jan 2015 13:42 Adam Klein notifications@github.com wrote:

@aexmachina https://github.com/aexmachina this stinks, I am removing
this. why did someone put this in the ember-cli 0.1.7 and not test this?

—
Reply to this email directly or view it on GitHub
#18 (comment)
.

cmosguy · 2015-01-14T02:47:46Z

@aexmachina I am interested in understanding more about this module, but there is absolutely no documention anywhere on this github. Can you point me to anything?

simonexmachina · 2015-01-14T02:49:02Z

Nope, I know nothing about it either.

On Wed, 14 Jan 2015 13:47 Adam Klein notifications@github.com wrote:

@aexmachina https://github.com/aexmachina I am interested in
understanding more about this module, but there is absolutely no
documention anywhere on this github. Can you point me to anything?

—
Reply to this email directly or view it on GitHub
#18 (comment)
.

quaertym · 2015-01-14T02:54:36Z

@aexmachina I cannot reproduce the issue, it gives the expected output. Do you have a specific example that demonstrates this issue?

simonexmachina · 2015-01-14T02:55:38Z

In out right now, but I can try when I get back

On Wed, 14 Jan 2015 13:54 Emre Unal notifications@github.com wrote:

@aexmachina https://github.com/aexmachina I cannot reproduce the issue,
it gives the expected output. Do you have a specific example that
demonstrates this issue?

—
Reply to this email directly or view it on GitHub
#18 (comment)
.

quaertym · 2015-01-14T03:01:18Z

@cmosguy This repo is well tested for many main scenarios we can imagine. See https://github.com/quaertym/ember-cli-dependency-checker/tree/master/tests. Please submit a failing test if you have a specific scenario that is not satisfied.

quaertym · 2015-01-14T19:54:32Z

@aexmachina any updates?

simonexmachina · 2015-01-14T21:56:01Z

Just getting to it now...

cmosguy · 2015-01-14T22:11:45Z

OK, so here is one problem:

version: 0.1.2
Object #<Project> has no method 'bowerDependencies'
TypeError: Object #<Project> has no method 'bowerDependencies'
    at EmberCLIDependencyChecker.readBowerDependencies (c:\Users\kleinada\workspace\squarekings\ember-app\node_modules\ember-cli-dependency-checker\lib\dependency-checker.js:80:35)
    at EmberCLIDependencyChecker.checkDependencies (c:\Users\kleinada\workspace\squarekings\ember-app\node_modules\ember-cli-dependency-checker\lib\dependency-checker.js:28:24)
    at new EmberCLIDependencyChecker (c:\Users\kleinada\workspace\squarekings\ember-app\node_modules\ember-cli-dependency-checker\lib\dependency-checker.js:19:8)
    at c:\Users\kleinada\workspace\squarekings\ember-app\node_modules\ember-cli\lib\models\project.js:206:25
    at visit (c:\Users\kleinada\workspace\squarekings\ember-app\node_modules\ember-cli\lib\utilities\DAG.js:23:3)
    at DAG.topsort (c:\Users\kleinada\workspace\squarekings\ember-app\node_modules\ember-cli\lib\utilities\DAG.js:82:7)
    at Project.initializeAddons (c:\Users\kleinada\workspace\squarekings\ember-app\node_modules\ember-cli\lib\models\project.js:202:9)
    at Project.eachAddonCommand (c:\Users\kleinada\workspace\squarekings\ember-app\node_modules\ember-cli\lib\models\project.js:229:10)
    at module.exports (c:\Users\kleinada\workspace\squarekings\ember-app\node_modules\ember-cli\lib\cli\lookup-command.js:52:13)
    at CLI.<anonymous> (c:\Users\kleinada\workspace\squarekings\ember-app\node_modules\ember-cli\lib\cli\cli.js:31:26)

Here is bower.json: https://gist.github.com/cmosguy/bd2321a8c62599124235
package.json: https://gist.github.com/cmosguy/68ed838076c43d06ebc2

What should I do here?

Thanks,
Adam

quaertym · 2015-01-14T22:31:27Z

@cmosguy What's your ember-cli and ember-cli-dependency-checker version?
edit: ok ember-cli is 0.1.2

cmosguy · 2015-01-14T22:32:21Z

@quaertym ember-cli 0.1.2 and whatever version you get for the checker when you do npm install.

quaertym · 2015-01-14T22:34:46Z

@cmosguy OK, bowerDependencies() added to ember-cli with version 0.1.3. The way to fix this is to upgrade ember-cli or downgrade ember-cli-dependency-checker to v0.0.5.

cmosguy · 2015-01-14T22:48:30Z

@quaertym just find this: ember-cli/ember-cli#2567 which relates to what you were talking about.

quaertym · 2015-01-14T23:43:39Z

@aexmachina OK, closing this issue now, if you find a specific case where dependency checker fails please submit another issue.

simonexmachina · 2015-01-15T21:50:07Z

Okay, happy for you to close it, but this is definitely still an issue. I
just haven't had a chance to provide an example.

quaertym · 2015-01-15T22:46:15Z

@aexmachina I do not get how it is an issue if you cannot provide an example.

simonexmachina · 2015-01-16T06:40:34Z

I've submitted a PR which provides a better error message. For some reason the bower package for swfobject has a .bower.json file that doesn't provide a version. When this happens ember-cli-dependency-checker assumes a version of *, which makes server.satisfies() throw an error.

Not sure what the correct behaviour should be. Any suggestions?

quaertym · 2015-01-16T09:49:35Z

@aexmachina Hmm, swfobject case is interesting. The latest stable release of swfobject is 2.2 which is not a valid semantic version. A valid semver version should be like 2.2.0. I do not think it is a scalable solution to cover all non-standard bower packages. I think submiting a pr about proper bower.json to the upstream repo(swfobject in this case) is a solution that benefits not just ember-cli users but a larger community.

simonexmachina · 2015-01-17T06:11:55Z

Cool, I'll create a PR for swfobject. Looks like they're already on it for their v2.3.0 release but it's still beta right now.

walter · 2015-02-06T06:30:17Z

I tracked down my instance of the same issue to Sanitize.js from within ember-sanitize add-on (in my case I was using ember-cli 0.1.12). There is already an issue requesting semver to be added to Sanitize.js, though I'm not holding my breath.

Looking for a workaround.

walter · 2015-02-06T22:06:09Z

Ok, my issue is sorted, too.

I added the diplomatic comment to the existing Sanitize.js issue and all that was needed was adding a semver compliant tag to the repository and then everything just worked.

So lesson is to figure out what bower packaged lib isn't properly semver tagged and ask the maintainer to add it.

quaertym · 2015-02-06T23:42:09Z

@walter Great 👍 otherwise it would be very hard to workaround all those non-semver packages.

karri-sek · 2015-04-20T09:47:28Z

Hi Getting the same error: after running this command:
Command:
git add -f bower_components/ember/ember.js bower_components/ember/ember.prod.js bower_components/ember-cli-shims/app-shims.js bower_components/ember-cli-test-loader/test-loader.js bower_components/ember-data/ember-data.js bower_components/ember-data/ember-data.prod.js bower_components/ember-load-initializers/ember-load-initializers.js bower_components/ember-resolver/dist/modules/ember-resolver.js bower_components/jquery/dist/jquery.js bower_components/loader/loader.js bower_components/handlebars/handlebars.js bower_components/handlebars/handlebars.runtime.js

I ran the above command inorder to make my ember cli build process faster.
for more details please visit this link.
http://stackoverflow.com/questions/24782479/how-to-debug-slow-ember-cli-broccoli-builds

Then results me the following error:

D:\software\emberProjects\todomvc-embercli>ember serve
Invalid Version: *
TypeError: Invalid Version: *
at new SemVer (D:\software\emberProjects\todomvc-emb
95:11)
at Range.test (D:\software\emberProjects\todomvc-emb
049:15)
at Function.satisfies (D:\software\emberProjects\tod
ver.js:1098:16)
at Package.updateRequired (D:\software\emberProjects
8)
at new Package (D:\software\emberProjects\todomvc-em
at EmberCLIDependencyChecker. (D:\softwar
dependency-checker.js:85:12)
at Array.map (native)
at EmberCLIDependencyChecker.readBowerDependencies (
ecker\lib\dependency-checker.js:82:36)

dangreenisrael · 2015-10-21T07:54:49Z

I just got the same error after running some updates. It's not the first time that it's happened either.

Here is my package.json

{
  "name": "whats-due-cordova",
  "version": "0.0.0",
  "description": "Small description for whats-due-cordova goes here",
  "private": true,
  "directories": {
    "doc": "doc",
    "test": "tests"
  },
  "scripts": {
    "build": "ember build",
    "start": "ember server",
    "test": "ember test"
  },
  "repository": "",
  "engines": {
    "node": ">= 0.10.0"
  },
  "author": "",
  "license": "MIT",
  "devDependencies": {
    "broccoli-asset-rev": "^2.1.2",
    "ember-bootstrap-switch": "0.2.0",
    "ember-cli": "1.13.8",
    "ember-cli-app-version": "0.5.0",
    "ember-cli-babel": "^5.1.3",
    "ember-cli-content-security-policy": "0.4.0",
    "ember-cli-delay-app-boot": "1.0.2",
    "ember-cli-dependency-checker": "1.0.1",
    "ember-cli-fastclick": "1.0.4",
    "ember-cli-font-awesome": "0.1.1",
    "ember-cli-htmlbars": "0.7.9",
    "ember-cli-htmlbars-inline-precompile": "^0.2.0",
    "ember-cli-ic-ajax": "0.2.1",
    "ember-cli-inject-live-reload": "^1.3.1",
    "ember-cli-less": "1.3.3",
    "ember-cli-qunit": "^1.0.0",
    "ember-cli-release": "0.2.3",
    "ember-cli-remote-inspector": "^0.1.0",
    "ember-cli-sri": "^1.0.3",
    "ember-cli-uglify": "^1.2.0",
    "ember-data": "2.0.0",
    "ember-disable-proxy-controllers": "^1.0.0",
    "ember-export-application-global": "^1.0.3",
    "ember-group-by": "0.0.2",
    "ember-in-viewport": "2.0.0",
    "ember-infinity": "0.1.2",
    "ember-localforage-adapter": "2.0.0"
  }
}

Here is my bower.json

{
  "name": "whats-due-cordova",
  "dependencies": {
    "ember": "^2.0.0",
    "ember-cli-test-loader": "ember-cli-test-loader#0.1.3",
    "ember-data": "^2.0.0",
    "ember-load-initializers": "ember-cli/ember-load-initializers#0.1.5",
    "ember-qunit": "0.4.9",
    "ember-qunit-notifications": "0.0.7",
    "ember-resolver": "~0.1.18",
    "jquery": "^1.11.3",
    "loader.js": "ember-cli/loader.js#3.2.1",
    "qunit": "~1.18.0",
    "moment": "~2.10.2",
    "moment-timezone": "~0.4.0",
    "fastclick": "~1.0.6",
    "localforage": "~1.2.1",
    "bootstrap-switch": "^3.3.2",
    "font-awesome": "~4.4.0"
  },
  "resolutions": {
    "ember": "^2.0.0"
  }
}

Note, I have run
bower prune
bower cache clean
npm cache clean
all with no luck
I'm going to look for a workaround

dangreenisrael · 2015-10-21T07:55:22Z

here is my error message

Invalid Version: *
TypeError: Invalid Version: *
    at new SemVer (/Users/Dan/Git Repos/WhatsDue App/source/node_modules/ember-cli-dependency-checker/node_modules/semver/semver.js:295:11)
    at Range.test (/Users/Dan/Git Repos/WhatsDue App/source/node_modules/ember-cli-dependency-checker/node_modules/semver/semver.js:1049:15)
    at Function.satisfies (/Users/Dan/Git Repos/WhatsDue App/source/node_modules/ember-cli-dependency-checker/node_modules/semver/semver.js:1098:16)
    at Function.VersionChecker.satisfies (/Users/Dan/Git Repos/WhatsDue App/source/node_modules/ember-cli-dependency-checker/lib/version-checker.js:31:17)
    at Package.updateRequired (/Users/Dan/Git Repos/WhatsDue App/source/node_modules/ember-cli-dependency-checker/lib/package.js:19:26)
    at Package.init (/Users/Dan/Git Repos/WhatsDue App/source/node_modules/ember-cli-dependency-checker/lib/package.js:14:27)
    at new Package (/Users/Dan/Git Repos/WhatsDue App/source/node_modules/ember-cli-dependency-checker/lib/package.js:4:13)
    at EmberCLIDependencyChecker.<anonymous> (/Users/Dan/Git Repos/WhatsDue App/source/node_modules/ember-cli-dependency-checker/lib/dependency-checker.js:109:12)
    at Array.map (native)
    at EmberCLIDependencyChecker.readBowerDependencies (/Users/Dan/Git Repos/WhatsDue App/source/node_modules/ember-cli-dependency-checker/lib/dependency-checker.js:106:36)

dangreenisrael · 2015-10-21T07:56:23Z

I also moved between git branches, I suspect that this may have something to do with it.

Although, I have all of my vendors in .gitignore

dangreenisrael · 2015-10-21T08:39:34Z

I wound up solving it by following the steps for an update (I did not do an update)

https://github.com/ember-cli/ember-cli/releases

Hope this helps

quaertym · 2015-10-21T11:48:59Z

@dangreenisrael Glad it is solved for you.

aanand-drg · 2016-04-14T11:04:04Z

@dangreenisrael I had the same issue, your link solved this for me.

quaertym closed this as completed Jan 14, 2015

simonexmachina mentioned this issue Jan 16, 2015

Improve the error message when semver.satisfies() throws #20

Closed

cwarny mentioned this issue Feb 9, 2015

d3-plugins is not semver-compliant d3/d3-plugins#122

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

semver doesn't recognise a version of "*" #18

semver doesn't recognise a version of "*" #18

simonexmachina commented Jan 13, 2015

cmosguy commented Jan 14, 2015

simonexmachina commented Jan 14, 2015

cmosguy commented Jan 14, 2015

simonexmachina commented Jan 14, 2015

cmosguy commented Jan 14, 2015

simonexmachina commented Jan 14, 2015

quaertym commented Jan 14, 2015

simonexmachina commented Jan 14, 2015

quaertym commented Jan 14, 2015

quaertym commented Jan 14, 2015

simonexmachina commented Jan 14, 2015

cmosguy commented Jan 14, 2015

quaertym commented Jan 14, 2015

cmosguy commented Jan 14, 2015

quaertym commented Jan 14, 2015

cmosguy commented Jan 14, 2015

quaertym commented Jan 14, 2015

simonexmachina commented Jan 15, 2015

quaertym commented Jan 15, 2015

simonexmachina commented Jan 16, 2015

quaertym commented Jan 16, 2015

simonexmachina commented Jan 17, 2015

walter commented Feb 6, 2015

walter commented Feb 6, 2015

quaertym commented Feb 6, 2015

karri-sek commented Apr 20, 2015

dangreenisrael commented Oct 21, 2015

dangreenisrael commented Oct 21, 2015

dangreenisrael commented Oct 21, 2015

dangreenisrael commented Oct 21, 2015

quaertym commented Oct 21, 2015

aanand-drg commented Apr 14, 2016

semver doesn't recognise a version of "*" #18

semver doesn't recognise a version of "*" #18

Comments

simonexmachina commented Jan 13, 2015

cmosguy commented Jan 14, 2015

simonexmachina commented Jan 14, 2015

cmosguy commented Jan 14, 2015

simonexmachina commented Jan 14, 2015

cmosguy commented Jan 14, 2015

simonexmachina commented Jan 14, 2015

quaertym commented Jan 14, 2015

simonexmachina commented Jan 14, 2015

quaertym commented Jan 14, 2015

quaertym commented Jan 14, 2015

simonexmachina commented Jan 14, 2015

cmosguy commented Jan 14, 2015

quaertym commented Jan 14, 2015

cmosguy commented Jan 14, 2015

quaertym commented Jan 14, 2015

cmosguy commented Jan 14, 2015

quaertym commented Jan 14, 2015

simonexmachina commented Jan 15, 2015

quaertym commented Jan 15, 2015

simonexmachina commented Jan 16, 2015

quaertym commented Jan 16, 2015

simonexmachina commented Jan 17, 2015

walter commented Feb 6, 2015

walter commented Feb 6, 2015

quaertym commented Feb 6, 2015

karri-sek commented Apr 20, 2015

dangreenisrael commented Oct 21, 2015

dangreenisrael commented Oct 21, 2015

dangreenisrael commented Oct 21, 2015

dangreenisrael commented Oct 21, 2015

quaertym commented Oct 21, 2015

aanand-drg commented Apr 14, 2016