Detect npm >=3.9.2 and adjust the install command accordingly #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npm v3.9.1 included a fix for the bug which makes the `rm -rf node_modules` necessary ( npm/npm#12372 ), but also exposed a different bug which was fixed in npm v3.9.2 ( npm/npm#12724 )
|
@misterbyrne do we trust NPM working correctly in this place? I've seen some issues re: non-deterministic installations, and partial installs/updates. |
|
Since we are dropping support for node v4.x, does that mean we're also dropping support for npm 3.x? Perhaps this PR should be closed unmerged. |
|
I've left this hanging around too long anyway, so I'm happy to close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With later versions of npm, it's no longer necessary to
rm -rf node_modulesbeforenpm installwhen sub-dependency versions are not correct.npm v3.9.1 fixed the issue, but also exposed a different bug which was fixed in npm v3.9.2