Update ember-cli #91
Update ember-cli #91
Conversation
package.json
Outdated
| }, | ||
| "engines": { | ||
| "node": ">= 4" | ||
| "node": "6.* || 8.* || >= 10.*" |
There was a problem hiding this comment.
Oops, it looks like causes some problems. Do we want/need to keep support for node 4 to avoid a breaking change?
jacobq
force-pushed
the
update-ember-cli
branch
3 times, most recently
from
a1c5af3
to
1fa0393
Compare
appveyor.yml
Outdated
| @@ -7,15 +7,15 @@ init: | |||
| # Test against these versions of Node.js. | |||
| environment: | |||
| matrix: | |||
| - nodejs_version: "4" | |||
There was a problem hiding this comment.
We can follow ember-cli here and remove version 4.
|
I just realized that e-cli 3.2.0 drops node 4.x support, so attempting to use it triggers an 'incompatible module' error. Hence, if we want to update here as I was thinking then we'd need to drop 4.x support. Perhaps that should wait until a major release. Feel free to close this PR if you don't want to drop node 4.x support. |
|
Please also rebase master and squash commits. |
|
Do you want them all squashed (i.e. down to 1 single commit) or grouped (e.g. squash all of the e-cli updates, but keep the var->let/const separate)? (I was just following the recommendation of updating in stages but don't care either way.) I've now rebased with master and squashed down to 3 commits (ember-cli update, var->let/const, and dependency upgrade). |
|
Thanks! |
This PR is just optional clean-up. e.g. run
ember-cli-updateto sync-up with what ember-cli v3.2.0 generates for new addons, and also tweak CI setup.