method_missing should always be private

config/environment.rb

@@ -1,6 +1,7 @@
 require 'rubygems'
 gem 'activesupport', '~> 2.3.0'
 gem 'activerecord', '~> 2.3.0'
+gem 'actionpack', '~> 2.3.0'
 gem 'rspec', '>= 1.3.0'
 
 require 'action_controller'

lib/cash/buffered.rb

@@ -80,15 +80,12 @@ def flush
       end
     end
 
-    def method_missing(method, *args, &block)
-      @cache.send(method, *args, &block)
-    end
-
     def respond_to?(method)
       @cache.respond_to?(method)
     end
 
     protected
+
     def perform_commands
       @commands.each do |command|
         command.call(@cache)
@@ -98,6 +95,12 @@ def perform_commands
     def buffer_command(command)
       @commands << command
     end
+
+    private
+
+    def method_missing(method, *args, &block)
+      @cache.send(method, *args, &block)
+    end
   end
 
   class NestedBuffered < Buffered

lib/cash/local.rb

@@ -12,12 +12,6 @@ def cache_locally
     ensure
       @remote_cache = original_cache
     end
-
-    def method_missing(method, *args, &block)
-      autoload_missing_constants do
-        @remote_cache.send(method, *args, &block)
-      end
-    end
 
     def autoload_missing_constants
       yield if block_given?
@@ -29,6 +23,14 @@ def autoload_missing_constants
         raise error
       end
     end
+
+    private
+
+    def method_missing(method, *args, &block)
+      autoload_missing_constants do
+        @remote_cache.send(method, *args, &block)
+      end
+    end
   end
 
   class LocalBuffer
@@ -65,6 +67,8 @@ def delete(key, *options)
       @local_cache.delete(key)
     end
 
+    private
+
     def method_missing(method, *args, &block)
       @remote_cache.send(method, *args, &block)
     end

lib/cash/transactional.rb

@@ -22,15 +22,16 @@ def transaction
       end
     end
 
-    def method_missing(method, *args, &block)
-      @cache.send(method, *args, &block)
-    end
-
     def respond_to?(method)
       @cache.respond_to?(method)
     end
 
     private
+
+    def method_missing(method, *args, &block)
+      @cache.send(method, *args, &block)
+    end
+
     def begin_transaction
       @cache = Buffered.push(@cache, @lock)
     end

spec/cash/buffered_spec.rb

@@ -0,0 +1,9 @@
+require "spec_helper"
+
+module Cash
+  describe Buffered do
+    it "should have method missing as a private method" do
+      Buffered.private_instance_methods.should include("method_missing")
+    end
+  end
+end

spec/cash/local_buffer_spec.rb

@@ -0,0 +1,9 @@
+require "spec_helper"
+
+module Cash
+  describe LocalBuffer do
+    it "should have method missing as a private method" do
+      LocalBuffer.private_instance_methods.should include("method_missing")
+    end
+  end
+end

spec/cash/local_spec.rb

@@ -0,0 +1,9 @@
+require "spec_helper"
+
+module Cash
+  describe Local do
+    it "should have method missing as a private method" do
+      Local.private_instance_methods.should include("method_missing")
+    end
+  end
+end

spec/cash/transactional_spec.rb

@@ -570,5 +570,9 @@ module Cash
         end
       end
     end
+
+    it "should have method_missing as a private method" do
+      Transactional.private_instance_methods.should include("method_missing")
+    end
   end
 end