Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Land element in prices has type string #82

Closed
rspuler opened this issue Feb 1, 2019 · 2 comments
Closed

Land element in prices has type string #82

rspuler opened this issue Feb 1, 2019 · 2 comments
Labels
Bug Broken functionality
Milestone

Comments

@rspuler
Copy link

rspuler commented Feb 1, 2019

Problem description

The land element in the price section has type string. All other prices are of type positiveInteger.
Is there a reason for it? The description suggests that it is always in square meters.

<xs:element name="land" type="xs:string" minOccurs="0" maxOccurs="1">
  <xs:annotation>
    <xs:documentation>Land price per m²</xs:documentation>
  </xs:annotation>
</xs:element>

Desired Solution

The element land should also have type xs:positiveInteger

@jaggli jaggli added the Bug Broken functionality label Feb 3, 2019
@jensstalder
Copy link
Collaborator

jensstalder commented Jun 7, 2019

Does seam like a mistake, but I can weakly remember that there was a reason?

@jensstalder
Copy link
Collaborator

propertyLandPrice was moved to here as "land" from the old spec.

The original propertyLandPrice was never used. We will remove it for now in 2.0

@jaggli jaggli added this to the 2.0.0 milestone Jun 7, 2019
jaggli pushed a commit that referenced this issue Jun 7, 2019
@jaggli jaggli closed this as completed Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Broken functionality
Projects
None yet
Development

No branches or pull requests

3 participants