Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

login assertion: check for interrupted login #6

Open
colin-kiegel opened this issue Feb 10, 2017 · 3 comments
Open

login assertion: check for interrupted login #6

colin-kiegel opened this issue Feb 10, 2017 · 3 comments

Comments

@colin-kiegel
Copy link
Contributor

The login assertion currently only has a negative check, that it does not see the login form again. This will discover wrong credentials.

The assertions does not check for interrupted logins due to:

  • request to change password
  • request to accept user agreement

Reusability + out-of-the-box experience is a key goal of this testsuite.
But we don't know the startpage of other ILIAS installations.
Therefore it's hard to make a positive assertion for regular logins.

Suggestion

We could switch the login to a permanent login to the ILIAS repository goto.php?target=root_1&client_id=…. Then a positive assertion is possible without breaking the testsuite for other installations. However this would lead to different testresults (a permanentlinks adds another redirect).

cc @Amstutz

@colin-kiegel
Copy link
Contributor Author

The assertions could then be copy-pasted from the GET Repository testcase.

@Amstutz
Copy link

Amstutz commented Feb 10, 2017

I think this is a good suggestion. However currently I would rate the stability of the testsuite running for 5.3 higher. We need a set of comparable results for the next few month. We should can tackle this in autumn.

@Amstutz
Copy link

Amstutz commented Feb 10, 2017

If you think this will not impact the results (too much). I am completely in for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants