Exceptions being thrown from DeviceMonitor Dispose()

[vflame]

When Dispose is called on DeviceMonitor after being Started, AdbExceptions are thrown from this.monitorTask.Wait();. Throwing exceptions from dispose is a bad practice.

Repro:

            var socket = new AdbSocket(new IPEndPoint(IPAddress.Loopback, AdbClient.AdbServerPort));
            using (DeviceMonitor monitor = new DeviceMonitor(Socket))
            {
                monitor.Start();
                Thread.Sleep(1000);
                monitor.Dispose(); //exception thrown
            }

[bddckr]

I'm seeing the same after the recent refactoring work (which I love btw!). In my case it's an AdbException that has an inner exception of a SocketException. For now I'm using this:

try
{
    monitor.Dispose();
}
catch (AggregateException exception) when (
    exception.Flatten().InnerExceptions is ReadOnlyCollection<Exception> innerExceptions
    && innerExceptions.Count == 1 && innerExceptions[0] is AdbException)
{
    // Ignored.
}