-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix parallel code for quanteda 4.0 #72
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any idea what's causing the segfaults from running this on Ubuntu? Is that because it needs quanteda 4.0?
|
It is probably because proxyC still uses RcppParallel. I have a branch to
remove the dependency.
…On Mon, Apr 1, 2024, 21:03 Kenneth Benoit ***@***.***> wrote:
Any idea what's causing the segfaults from running this on Ubuntu? Is that
because it needs *quanteda* 4.0?
> dfmat <- corpus_subset(data_corpus_inaugural, Year > 2000) %>%
+ tokens(remove_punct = TRUE) %>%
+ tokens_remove(stopwords("english")) %>%
+ dfm()
> (tstat1 <- textstat_simil(dfmat, method = "cosine", margin = "documents"))
*** caught segfault ***
—
Reply to this email directly, view it on GitHub
<#72 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABSEXIZ3MMSKCM7PJJHZS2TY3FEJLAVCNFSM6AAAAABFOMCO7OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRZGY2TGNBSGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Ok, sounds like then
Resubmit proxyc
Resubmit stats and models
Then, quanteda
All this because rcpparallel won’t maintain the tbb code consistently!
Sent from Outlook for iOS<https://aka.ms/o0ukef>
________________________________
From: Kohei Watanabe ***@***.***>
Sent: Monday, April 1, 2024 2:09:03 PM
To: quanteda/quanteda.textstats ***@***.***>
Cc: Benoit,KR ***@***.***>; Review requested ***@***.***>
Subject: Re: [quanteda/quanteda.textstats] Fix parallel code for quanteda 4.0 (PR #72)
It is probably because proxyC still uses RcppParallel. I have a branch to
remove the dependency.
On Mon, Apr 1, 2024, 21:03 Kenneth Benoit ***@***.***> wrote:
Any idea what's causing the segfaults from running this on Ubuntu? Is that
because it needs *quanteda* 4.0?
> dfmat <- corpus_subset(data_corpus_inaugural, Year > 2000) %>%
+ tokens(remove_punct = TRUE) %>%
+ tokens_remove(stopwords("english")) %>%
+ dfm()
> (tstat1 <- textstat_simil(dfmat, method = "cosine", margin = "documents"))
*** caught segfault ***
—
Reply to this email directly, view it on GitHub
<#72 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABSEXIZ3MMSKCM7PJJHZS2TY3FEJLAVCNFSM6AAAAABFOMCO7OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRZGY2TGNBSGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
—
Reply to this email directly, view it on GitHub<#72 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAQUYZVUTTBERTI2FTJBY3LY3FL67AVCNFSM6AAAAABFOMCO7OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRZG4ZTGOJSHE>.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
kbenoit
reviewed
Apr 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@koheiw is this failing on the ubuntu platfoms because it is not getting the newest proxyC yet?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update code for quanteda v4.0.