Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for deprecated Matrix calls and for forthcoming Matrix 1.4-2 #2182

Merged
merged 10 commits into from Aug 28, 2022

Conversation

kbenoit
Copy link
Collaborator

@kbenoit kbenoit commented Aug 26, 2022

  • fixes deprecated as() calls (mostly as(., "dgCMatrix") which we'd used a lot)
  • turns on errors for using deprecated versions using options(Matrix.warnDeprecatedCoerce = 2) in testthat.R
  • works for forthcoming Matrix 1.4.2 release (tested from r-forge installation)

@kbenoit kbenoit requested a review from koheiw August 26, 2022 08:59
@kbenoit
Copy link
Collaborator Author

kbenoit commented Aug 26, 2022

Tests above are failing but it does pass cleanly with Matrix 1.4-2. I need to test more with current CRAN release of Matrix too.

R/fcm.R Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 27, 2022

Codecov Report

Merging #2182 (4cc347b) into master (9a06c2b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2182   +/-   ##
=======================================
  Coverage   96.43%   96.43%           
=======================================
  Files          87       87           
  Lines        5099     5100    +1     
=======================================
+ Hits         4917     4918    +1     
  Misses        182      182           
Impacted Files Coverage Δ
R/dfm-classes.R 94.73% <ø> (ø)
R/convert.R 93.33% <100.00%> (ø)
R/dfm-methods.R 97.05% <100.00%> (ø)
R/dfm.R 99.04% <100.00%> (ø)
R/dfm_group.R 98.46% <100.00%> (ø)
R/dfm_weight.R 95.68% <100.00%> (ø)
R/fcm-methods.R 91.89% <100.00%> (-0.42%) ⬇️
R/fcm.R 100.00% <100.00%> (ø)
R/object-builder.R 91.91% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

R/dfm.R Outdated Show resolved Hide resolved
Kenneth Benoit added 4 commits August 28, 2022 10:35
Did this since it seems to fail in the PR checks build, and since I have a local check for this anyway (on my local machine).
R/dfm-methods.R Outdated Show resolved Hide resolved
R/fcm-methods.R Outdated Show resolved Hide resolved
R/fcm.R Outdated Show resolved Hide resolved
R/fcm.R Outdated Show resolved Hide resolved
R/object-builder.R Outdated Show resolved Hide resolved
tests/testthat.R Outdated Show resolved Hide resolved
Copy link
Collaborator

@koheiw koheiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you for your work.

@kbenoit kbenoit merged commit d74c253 into master Aug 28, 2022
@kbenoit kbenoit deleted the Matrix_1.4-2 branch August 28, 2022 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants