New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for deprecated Matrix calls and for forthcoming Matrix 1.4-2 #2182
Conversation
Tests above are failing but it does pass cleanly with Matrix 1.4-2. I need to test more with current CRAN release of Matrix too. |
Codecov Report
@@ Coverage Diff @@
## master #2182 +/- ##
=======================================
Coverage 96.43% 96.43%
=======================================
Files 87 87
Lines 5099 5100 +1
=======================================
+ Hits 4917 4918 +1
Misses 182 182
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Did this since it seems to fail in the PR checks build, and since I have a local check for this anyway (on my local machine).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thank you for your work.
as()
calls (mostlyas(., "dgCMatrix")
which we'd used a lot)options(Matrix.warnDeprecatedCoerce = 2)
intestthat.R