Address #2008 #2010
Merged
Address #2008 #2010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2010 +/- ##
=======================================
Coverage 90.15% 90.15%
=======================================
Files 102 102
Lines 6512 6513 +1
=======================================
+ Hits 5871 5872 +1
Misses 641 641
Continue to review full report at Codecov.
|
kbenoit
approved these changes
Nov 24, 2020
| @@ -103,7 +103,8 @@ kwic.tokens <- function(x, pattern, window = 5, | |||
| names(pattern) <- pattern | |||
|
|
|||
| valuetype <- match.arg(valuetype) | |||
| window <- as.integer(window) | |||
| window <- as.integer(window[1]) | |||
There was a problem hiding this comment.
Shouldn't we issue some warning, such as
'window' has length > 1 and only the first element will be used
|
Once merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #2008