Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve unregistered symbol issue #866

Merged
merged 2 commits into from
Jul 21, 2017
Merged

Solve unregistered symbol issue #866

merged 2 commits into from
Jul 21, 2017

Conversation

HaiyanLW
Copy link
Collaborator

Fixed #846

@codecov
Copy link

codecov bot commented Jul 20, 2017

Codecov Report

Merging #866 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #866   +/-   ##
=======================================
  Coverage   77.59%   77.59%           
=======================================
  Files         106      106           
  Lines        7918     7918           
=======================================
  Hits         6144     6144           
  Misses       1774     1774

1 similar comment
@codecov
Copy link

codecov bot commented Jul 20, 2017

Codecov Report

Merging #866 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #866   +/-   ##
=======================================
  Coverage   77.59%   77.59%           
=======================================
  Files         106      106           
  Lines        7918     7918           
=======================================
  Hits         6144     6144           
  Misses       1774     1774

@HaiyanLW
Copy link
Collaborator Author

Inserted underscores, but the same NOTE is still there.

@kbenoit
Copy link
Collaborator

kbenoit commented Jul 20, 2017

I'm afraid this doesn't stop the NOTEs, either on my Windows 10 system or on Appeveyor... 😢

@kbenoit kbenoit merged commit f72361a into master Jul 21, 2017
@kbenoit kbenoit deleted the fix-846 branch August 10, 2017 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants