Issue 928 #931
Merged
Issue 928 #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also change how unused argument warning is given in tokens()
- decrease reliance on who_called_me_first() - solve #928 purrr::map() problem - consolidates print messaging in dfm() generic - adds tests for `dfm()` messages with `verbose = TRUE`
|
Note to @koheiw and @HaiyanLW: Appveyor is failing on this temporarily because of RcppCore/RcppArmadillo#161, which is fixed on CRAN just recently but only in the source so far. This is why Travis passes but Appveyor does not, because Appveyor wants to install the Windows binaries and they are not yet updated. |
|
I got it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #928.
dfm()messages withverbose = TRUE