Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Korean #37

Merged
merged 7 commits into from
Nov 17, 2020
Merged

Add Korean #37

merged 7 commits into from
Nov 17, 2020

Conversation

koheiw
Copy link
Contributor

@koheiw koheiw commented Nov 16, 2020

Add Korean to the marimo collection. Generate the table in RMD is generated from CSV to make it easy to update.

@koheiw koheiw requested a review from kbenoit November 16, 2020 23:18
kbenoit
kbenoit approved these changes Nov 17, 2020
View reviewed changes
Copy link
Collaborator

@kbenoit kbenoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice update, smart to move the table into CSV. I thought about automating it to populate this table from the actual objects, but that can be left for the future.

@koheiw
Copy link
Contributor Author

koheiw commented Nov 17, 2020

Nice update, smart to move the table into CSV. I thought about automating it to populate this table from the actual objects, but that can be left for the future.

I thought about it too, but didn't go that far yet.

@koheiw koheiw merged commit c45998c into master Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbenoit kbenoit kbenoit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koheiw @kbenoit