More typescript & cleanups #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for metaforecast ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
allowJs is set to false in tsconfig.json now; please write all future
code with typescript.
cleanups:
- removed platforms/deprecated
- removed flow/history/old
- see #22
- commented some invalid axios options
- minor fixes with mismatching function arguments
- commented invalid mongo call in databaseReadWithReadCredentials
- {encoding: 'utf-8'} in readFileSync calls
berekuk
force-pushed
the
more-typescript
branch
from
5c6eb0d
to
edeefdb
Compare
|
So the goodjudgment script doesn't currently work on heroku. But I figured it did work if I used, e.g., some proxies from Hetzner (https://spys.one/proxy-asn/24940/). This wasn't working, so my workaround is to run a crontab on my machine. But fixing the proxying would be great. |
Merged
|
Feel free to merge this @berekuk; I'm not seeing how that could cause any particular problems. |
|
Yeah, I'm going to merge this; don't think anything particularly bad will happen. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a second step in the transition to TypeScript (#7).
For now I:
Some axios calls had options not appropriate for axios, e.g.
referrer,agentandcredentials. I just commented those since everything works without them. But it's interesting that one of those (agent) was responsible forBACKUP_PROXYstuff on goodjudgement. Unsure, should I fix BACKUP_PROXY properly, or are we ok without it?PS: enabling
strictintsconfig.json(i.e., the actually useful mode which gives most benefits from using typescript) displays 523 errors. I'll either temporarily turn it on from time to time and try to bring this number down (without spending too much time on this), or wait until other code cleanups first.