change order of prop overriding

quantizor · Feb 28, 2019 · 9e8701e · 9e8701e
1 parent ac97191
commit 9e8701e
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 2 deletions.
diff --git a/index.compiler.spec.js b/index.compiler.spec.js
@@ -2966,8 +2966,8 @@ describe('overrides', () => {
     expect($element.outerHTML).toMatchInlineSnapshot(`
 
 <input type="checkbox"
-       class="foo"
        readonly
+       class="foo"
        value="on"
 >
 

diff --git a/index.component.spec.js b/index.component.spec.js
@@ -93,3 +93,19 @@ it('passes along any additional props to the rendered wrapper element', () => {
 
 `);
 });
+
+it('passes along any additional props including title to the rendered wrapper element', () => {
+  render(<Markdown className="foo" title="bar"># Hello</Markdown>);
+
+  expect(root.innerHTML).toMatchInlineSnapshot(`
+
+<h1 data-reactroot
+    id="hello"
+    class="foo"
+	title="bar"
+>
+  Hello
+</h1>
+
+`);
+});
diff --git a/index.js b/index.js
@@ -727,8 +727,8 @@ export function compiler(markdown, options) {
     return createElementFn(
       getTag(tag, options.overrides),
       {
-        ...overrideProps,
         ...props,
+        ...overrideProps,
         className:
           cx(props && props.className, overrideProps.className) || undefined,
       },