Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for self-closing tags #140

Closed
Planeshifter opened this issue Dec 29, 2017 · 2 comments · Fixed by #142
Closed

Support for self-closing tags #140

Planeshifter opened this issue Dec 29, 2017 · 2 comments · Fixed by #142

Comments

@Planeshifter
Copy link

Planeshifter commented Dec 29, 2017

Thank you for this promising library, very useful indeed!

I have noticed that self-closing tags for React components are currently not parsed correctly when they span multiple lines.

While

<DatePicker biasTowardDateTime="2017-12-05T07:39:36.091Z" timezone="UTC+5" />

is correctly parsed,

<DatePicker 
    biasTowardDateTime="2017-12-05T07:39:36.091Z" 
    timezone="UTC+5" 
/>

is not. This is the case no matter how the JSX attributes are indented.

@Andreyco
Copy link

I experience different issue with self closing tags.

// Good
<br />

// Bad
<br/>

As you can see, space is required before /> characters.

@quantizor
Copy link
Owner

quantizor commented Oct 10, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants