fixes random order of binary file, which should have lead to wrong le…

…arning results; thanks to David-Elias
quantling · Feb 19, 2018 · 69fc3d2 · 69fc3d2
1 parent 38e76b7
commit 69fc3d2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/pyndl/__init__.py b/pyndl/__init__.py
@@ -17,7 +17,7 @@
 __author__ = ('Konstantin Sering, Marc Weitz, '
               'David-Elias Künstle, Lennard Schneider')
 __author_email__ = 'konstantin.sering@uni-tuebingen.de'
-__version__ = '0.4.3'
+__version__ = '0.4.4'
 __license__ = 'MIT'
 __description__ = ('Naive discriminative learning implements learning and '
                    'classification models based on the Rescorla-Wagner '

diff --git a/pyndl/ndl.py b/pyndl/ndl.py
@@ -169,6 +169,8 @@ def ndl(events, alpha, betas, lambda_=1.0, *,
         binary_files = [os.path.join(binary_path, binary_file)
                         for binary_file in os.listdir(binary_path)
                         if os.path.isfile(os.path.join(binary_path, binary_file))]
+        # sort binary files as they were created
+        binary_files.sort(key=lambda filename: int(os.path.basename(filename)[9:-4]))
         if verbose:
             print('start learning...')
         # learning