ENH Add beta fragility and gpd risk estimates #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
python 2 and 3
…y_and_gpd_risk_estimates Conflicts: empyrical/__init__.py empyrical/stats.py empyrical/tests/test_stats.py
- old tests work - new tests still failing
- fixes TypeError: cannot concatenate a non-NDFrame object - also, switch the functions from SIMPLE_STAT_FUNCS to FACTOR_STAT_FUNCS
…y_and_gpd_risk_estimates
|
Thanks - this looks great! |
|
In a separate PR, I would be curious to see maybe a quick tutorial as a jupyter NB on how to use and interpret this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks!
This is a continuation of the previous pull request here
I believe all previous comments have been addressed, but I wasn't quite sure of the proper format for the doc strings.
I just sort of landed here and tried to follow it.
I welcome all feedback on how to improve; thank you!
Jey