Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLD: Try out GH actions. #73

Merged
merged 1 commit into from
Apr 29, 2020
Merged

BLD: Try out GH actions. #73

merged 1 commit into from
Apr 29, 2020

Conversation

ssanderson
Copy link
Contributor

@ssanderson ssanderson commented Jan 30, 2020 •
edited
Loading

Switch over to building with GH Actions.

@ssanderson ssanderson force-pushed the gh-actions branch 3 times, most recently from 52a81b1 to 5cd978f Compare January 30, 2020 15:00
@ssanderson ssanderson mentioned this pull request Jan 30, 2020
Closed
dmichalowicz
dmichalowicz reviewed Feb 4, 2020
View reviewed changes
.github/workflows/ci.yaml Outdated
name:
- py27-notebook5
- py35-notebook5
- py35-notebook5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a duplicate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep.

@dmichalowicz
Copy link
Contributor

So is Travis supposed to still be running, or will that be gone after this merges?

@dmichalowicz
Copy link
Contributor

At the end of the "Run Tox" tasks I see a FileNotFoundError, does that mean anything?

@dmichalowicz dmichalowicz self-assigned this Feb 11, 2020
@ssanderson
Copy link
Contributor Author

So is Travis supposed to still be running, or will that be gone after this merges?

I'm gonna remove travis before merging this.

dmichalowicz
dmichalowicz approved these changes Feb 11, 2020
View reviewed changes
Copy link
Contributor

@dmichalowicz dmichalowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it could use some squashing of commits but otherwise lgtm.

@ssanderson
Copy link
Contributor Author

At the end of the "Run Tox" tasks I see a FileNotFoundError, does that mean anything?

I believe that's an error happening one of IPython's test utilities where they're holding a weakref to a temporary directory that ends up getting double-deleted on interpreter shutdown. It's not the greatest thing, but I don't think it's indicative of a concerning issue.

@ssanderson ssanderson merged commit 892b8d7 into master Apr 29, 2020
@ssanderson ssanderson deleted the gh-actions branch April 29, 2020 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmichalowicz dmichalowicz dmichalowicz approved these changes

Assignees

@dmichalowicz dmichalowicz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ssanderson @dmichalowicz