Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP8 and unify codebase #1

Closed
twiecki opened this issue Jun 8, 2015 · 5 comments
Closed

PEP8 and unify codebase #1

twiecki opened this issue Jun 8, 2015 · 5 comments
Assignees

Comments

@twiecki
Copy link
Contributor

twiecki commented Jun 8, 2015

Use e.g. autopep8 to make the syntax correspond to pep8.

Also, the functions use different naming conventions, change all to use underscore_style rather than camelCase.

@twiecki
Copy link
Contributor Author

twiecki commented Jun 15, 2015

@gusgordon This seems mostly done, no?

@gusgordon
Copy link
Contributor

Pretty much. There are some variable names that are still a bit questionable, though, like x_TS. I'll give those better names today then this can be closed.

@gusgordon
Copy link
Contributor

@justinlent Does it make sense to rename "algo_ts" to "df_cum_rets"? I think algo_ts is just the cumulative version of df_rets, no?

I think once those bt names get cleaned up and the above is sorted out this issue can be closed.

@justinlent
Copy link
Contributor

@gusgordon Yeah, I like that recommendation ^^ to rename algo_ts to the more informative 'df_cum_rets'

Also, I just responded in the HC room about some ideas for renaming the bt_* variables

@twiecki
Copy link
Contributor Author

twiecki commented Jun 23, 2015

+1

twiecki pushed a commit that referenced this issue Oct 4, 2015
twiecki pushed a commit that referenced this issue Feb 3, 2016
twiecki pushed a commit that referenced this issue Aug 28, 2019
DOC: fix docstring for rolling volatility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants