ENH: An improved error message when calling zipline api functions #1593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outside of a running simulation. Previously, an AttributeError was raised.
|
👍 from me |
|
The only change I could maybe see here is adding a specific exception type for this (e.g. |
|
+1 also, I think the runtime error is fine because I don't expect anyone to want to catch this |
|
Ok, cool, then I'm going to merge on travis passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
outside of a running simulation. Previously, an AttributeError was
raised.
The goal here is to make the situation clearer for developers, for example: #1541 and #448 (comment)
What do folks think of the message?