Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conflicting CLI flags for clean #1624

Closed
pgeez opened this issue Dec 24, 2016 · 3 comments · Fixed by #1625
Closed

conflicting CLI flags for clean #1624

pgeez opened this issue Dec 24, 2016 · 3 comments · Fixed by #1625
Assignees

Comments

@pgeez
Copy link

pgeez commented Dec 24, 2016

Dear Zipline Maintainers,

Before I tell you about my issue, let me describe my environment:

Environment

  • Operating System: OS X 10.12.1
  • Python Version: 2.7
  • Python Bitness: 64
  • How did you install Zipline: conda
  • Python packages: default

Now that you know a little about me, let me tell you about the issue I am
having:

Description of Issue

The CLI command zipline clean has conflicting flags for -b, --bundle and -b, --before.

(zipline-venv) pgeez$ zipline clean --help
Usage: zipline clean [OPTIONS]

  Clean up data downloaded with the ingest command.

Options:
  -b, --bundle BUNDLE-NAME  The data bundle to clean.  [default: quantopian-
                            quandl]
  -b, --before TIMESTAMP    Clear all data before TIMESTAMP. This may not be
                            passed with -k / --keep-last
  -a, --after TIMESTAMP     Clear all data after TIMESTAMP This may not be
                            passed with -k / --keep-last
  -k, --keep-last N         Clear all but the last N downloads. This may not
                            be passed with -b / --before or -a / --after
  --help                    Show this message and exit.
  • What happened instead?
    Because of the conflict, -b defaults to --before.

Sincerely,
pgeez

@llllllllll
Copy link
Contributor

Oops, sorry about that. Thanks for reporting this. Do you have a suggestion for a short-opt for before? I am thinking -f. Alternativly, if that is not that intuitive we could just remove the short-opt and require users to type --before.

@pgeez
Copy link
Author

pgeez commented Dec 25, 2016

Np.

e or f sound good to me; I really don't have an opinion. I do think, though, that you should have a short-opt for --before for the sake of consistency with other CLI args.

@freddiev4
Copy link
Contributor

Hey @pgeez this should be fixed now in the latest zipline master thanks to the PR linked above ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants