Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEV delete old *.c and *.so files with rebuild-cython.sh for Darwin/OSX #1560

Merged
merged 1 commit into from Oct 26, 2016
Merged

DEV delete old *.c and *.so files with rebuild-cython.sh for Darwin/OSX #1560

merged 1 commit into from Oct 26, 2016

Conversation

prsutherland
Copy link
Contributor

OSX's find supports a different syntax for -regex. As a result the original regex doesn't match any files and successfully does nothing.

I've confirmed that this change works with and without brew install findutils --with-default-names

@llllllllll
Copy link
Contributor

lgtm, merging on pass

@coveralls
Copy link

coveralls commented Oct 26, 2016 •
edited

Coverage Status

Coverage remained the same at 86.978% when pulling 810ee7f on rebuild_cython_osx into df2a091 on master.

@llllllllll llllllllll merged commit e7ca080 into master Oct 26, 2016
@llllllllll llllllllll deleted the rebuild_cython_osx branch October 26, 2016 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@llllllllll llllllllll

Labels
Bug Build Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@prsutherland @llllllllll @coveralls