New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Micro optimizations 2 #1561
Merged
Merged
Micro optimizations 2 #1561
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
a56fc70
PERF: Try cache on scalar asset lookups.
35a72f6
MAINT: Auto-rebuild templated cython files.
73cc580
PERF: Remove attribute access in inner loop.
20531fb
PERF: Vectorize assignments in get_history_window.
85fcf0b
BUG: Return NaT instead of None in daily reader.
502fbf5
PERF: Refactor AdjustedArrayWindow.
9d10e28
PERF: Use vectorized assignment into dataframe.
5547cca
PERF: Pull out loop-invariant code.
25c78de
MAINT/PERF: Remove redundant method call.
9e3eebc
PERF: Don't round until after we hstack.
70cc602
PERF: Call concatenate directly instead of hstack.
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should
Exhausted
be handled here? Or is the intent to have that raise for the consumer ofseek
to handle?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
if target_anchor < anchor:
check should precludeExhausted
ever being raised here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nvm, I misread the code. The check above is for making sure we don't seek backwards.
It's an error for the caller to try to seek past the end of the array. In the old code, that would fail with a
StopIteration
, which is actually probably bad because that can be caught and misinterpreted ifseek
is called inside a generator. I don't have a strong opinion on whether it's worthwhile to try to catch and re-raiseExhausted
here with a more descriptive error. Given that this is in performance-critical code, I'm inclined to say that this is fine as-is.