Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.6 Support #2643

Merged
merged 4 commits into from
Feb 4, 2020
Merged

Python 3.6 Support #2643

merged 4 commits into from
Feb 4, 2020

Conversation

dmichalowicz
Copy link
Contributor

Attempting #2512 (comment) by opening a branch as a Quantopian member. All credit for these changes goes to @Peque.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 87.701% when pulling 4b07d25 on q-py36 into 1abcb34 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 87.701% when pulling 4b07d25 on q-py36 into 1abcb34 on master.

@coveralls
Copy link

coveralls commented Feb 4, 2020

Coverage Status

Coverage remained the same at 88.273% when pulling fc9eb2f on q-py36 into 1abcb34 on master.

@Peque
Copy link
Contributor

Peque commented Feb 4, 2020

Mind commenting here with the results?

#2619

Specifying if you:

  • Are part of the Quantopian GitHub organization
  • Have an AppVeyor paying subscription.
  • Made any changes with respect to the original PR (Python 3.6 support #2512)

@Peque
Copy link
Contributor

Peque commented Feb 4, 2020

It seems pipelines do not get stuck for you! 😊

No idea about the error though.

@dmichalowicz
Copy link
Contributor Author

I did not make any changes from the original PR. It looks like maybe we need to bump the version of psutil? I'm not on a Windows machine but will try to debug further.

@Peque
Copy link
Contributor

Peque commented Feb 4, 2020

@dmichalowicz Yeah, I just tried to bump it in:

514d8c5

Let us see if pipelines pass (at least in Travis, you may need to pull the changes into your fork to make AppVeyor pass). 😅

@Peque
Copy link
Contributor

Peque commented Feb 4, 2020

@dmichalowicz It seems the psutil bump worked just fine, so you may want to try and push that last commit from my branch to see if it fixes the AppVeyor remaining issues. 😊

@Peque
Copy link
Contributor

Peque commented Feb 4, 2020

🎉 😊

@dmichalowicz
Copy link
Contributor Author

Thanks for your work on this @Peque and for your patience!

@dmichalowicz dmichalowicz merged commit 7c654ef into master Feb 4, 2020
@dmichalowicz dmichalowicz deleted the q-py36 branch February 4, 2020 21:27
@Peque Peque mentioned this pull request Feb 5, 2020
@dancju
Copy link

dancju commented May 18, 2020

When will the PyPI version of Zipline support Python 3.6?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants