List hdf5 as a dependency #2679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Possibly related to #2474, this dependency was a requirement for me to install zipline on arch.
richafrank
reviewed
Mar 31, 2020
There was a problem hiding this comment.
Thanks so much @daraul ! I agree hdf5 is a dependency that we should list.
I had a couple potential changes for you inline.
|
Thanks for the updates! I also don't know the correct package name for RHEL-derived linux distros, but if it's wrong, we can fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possibly related to #2474, this package was a requirement for me to install zipline on arch. I'm not sure that the package name for RHEL and ubuntu is correct, however.