H5 Minute Reader Bug in Python 3 #2680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmichalowicz
commented
Apr 1, 2020
etc/requirements_locked.txt
Outdated
| @@ -35,7 +35,7 @@ flask-cors==2.1.3 | |||
| flask==1.1.1 # via flask-cors | |||
| funcsigs==1.0.2 # via mock, python-interface | |||
| futures==3.2.0 # via tornado | |||
| h5py==2.7.1 | |||
| h5py==2.10.0 | |||
There was a problem hiding this comment.
This update was necessary to read the file's attr in the tests...2.7.1 was failing with a strange numpy c error.
dmichalowicz
force-pushed
the
read-hdf-fix-py3
branch
4 times, most recently
from
5a8ae0f
to
a0916f8
Compare
ssanderson
reviewed
Apr 2, 2020
zipline/data/minute_bars.py
Outdated
|
|
||
| # Our current version of h5py is unable to read the tz attr in the | ||
| # tests as it was written by HDFStore. This is fixed in version | ||
| # 2.10.0 of h5py, but that requires >=Python3.7, so until then we |
There was a problem hiding this comment.
I think 2.10 only requires python 3.7 on conda.
ssanderson
reviewed
Apr 2, 2020
There was a problem hiding this comment.
@dmichalowicz the logic here looks good to me. The only comment I had was that your comment currently says that we need python 3.7 to use the newer version of h5py. I don't think that's actually true in general, that's just for conda-based installs.
|
Right, thanks, I'll fix and then merge. |
dmichalowicz
force-pushed
the
read-hdf-fix-py3
branch
from
21dbcc4
to
a99401e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an equities or futures update file was written in python 2 but read in python 3,
pandas.read_hdfwould error trying to read the tz attr in the file.