Bundle fixes and documentation improvements #2733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richafrank
reviewed
Jul 16, 2020
| By default zipline comes with the ``quandl`` data bundle which uses quandl's | ||
| `WIKI dataset <https://www.quandl.com/data/WIKI>`_. The quandl data bundle | ||
| includes daily pricing data, splits, cash dividends, and asset metadata. To | ||
| ingest the ``quandl`` data bundle we recommend creating an account on quandl.com |
There was a problem hiding this comment.
Should we still document the quandl bundle somewhere?
There was a problem hiding this comment.
I don't think this bundle will still work, so we can remove it from the docs.
zipline/algorithm.py
Outdated
| @@ -140,6 +140,13 @@ | |||
| AttachedPipeline = namedtuple('AttachedPipeline', 'pipe chunks eager') | |||
|
|
|||
|
|
|||
| class NoBenchmark(ValueError): | |||
| def __init__(self): | |||
| super().__init__( | |||
There was a problem hiding this comment.
Reminder for py2 compat (for this release)
| } | ||
| ).run() | ||
| except NoBenchmark: | ||
| raise _RunAlgoError( |
There was a problem hiding this comment.
Nice use of _RunAlgoError. I hadn't remembered this existed.
Co-authored-by: Richard Frank <richafrank@users.noreply.github.com>
llllllllll
force-pushed
the
bundle-doc-improvements
branch
from
d48c90e
to
773ba6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quantopian-quandlthe default bundlequandlbundle as deprecated