Update the Dockerfile to use 3.6, requirements needed to be updated. #2741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@richafrank Dont know the process for this repo in details. Please let me know if im missing out on something! |
|
Thanks @lhjnilsson . We've started various tasks to improve our packaging situation. We'll take a look at this and the dockerfile as we continue in that vein... |
|
Cool @richafrank ! Really enjoy working with the things that you guys have created. Take care |
Swalloow
reviewed
Oct 21, 2020
| @@ -21,7 +21,7 @@ | |||
| # | |||
| # docker exec -it zipline zipline run -f /projects/my_algo.py --start 2015-1-1 --end 2016-1-1 -o /projects/result.pickle | |||
| # | |||
| FROM python:3.5 | |||
| FROM python:3.6 | |||
|
|
|||
| # | |||
| # set up environment | |||
There was a problem hiding this comment.
&& pip install 'scipy>=0.17.1,<1.0.0' \
this should be scipy>=0.17.1,<=1.1.0 due to statsmodels dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When requirements had a "softer" pin it seemed to get a Numpy which was incompatible.
Not sure how it works when building the code to a pypi.. ?
Thanks for making 3.6 possible!