Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Update source activate command to conda activate #2776

Merged

Conversation

leonarduschen
Copy link
Contributor

Zipline installation docs currently uses source activate and source deactivate - which only work on Linux and MacOS. So I thought we might want to change that to conda activate and conda deactivate as they are supported on all OS (available on Conda 4.4 onwards https://www.anaconda.com/blog/conda-4-6-release)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.26% when pulling 050365c on leonarduschen:update-conda-activate-command into 5e6c9fc on quantopian:master.

@leonarduschen
Copy link
Contributor Author

I'm not sure why the test fails. I thought it was the Miniconda version used in AppVeyor test, but it doesn't explain why the test fails only in this particular environment:

Environment: PYTHON_VERSION=3.6, PANDAS_VERSION=0.22.0, NUMPY_VERSION=1.14.1, SCIPY_VERSION=1.0.0, STATSMODELS_VERSION=0.9.0, PANDAS_DATAREADER_VERSION=0.4.0, DASK_VERSION=0.17.1

@richafrank
Copy link
Member

Thanks @leonarduschen ! I restarted the failed AppVeyor build, and it succeeded. And I think the note directive looks nice.

@richafrank richafrank merged commit dbcef66 into quantopian:master Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants