Asset KeyError #959
Merged
Asset KeyError #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richafrank
force-pushed
the
asset_keyerror
branch
from
460d45b
to
e590f37
Compare
| @@ -212,6 +212,7 @@ def test_asset_comparisons(self): | |||
| self.assertEqual(s_23, s_23) | |||
| self.assertEqual(s_23, 23) | |||
| self.assertEqual(23, s_23) | |||
| self.assertEqual(int64(23), s_23) | |||
There was a problem hiding this comment.
let's also check np.int32 to be safe
richafrank
force-pushed
the
asset_keyerror
branch
from
e590f37
to
e41961d
Compare
Also batch lookup sids in algo.run
richafrank
force-pushed
the
asset_keyerror
branch
from
e41961d
to
c26a499
Compare
We use a number of mappings keyed by int64, which otherwise raised KeyErrors for Assets.
richafrank
force-pushed
the
asset_keyerror
branch
from
c26a499
to
46a47d4
Compare
This was referenced Jan 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable comparison of an Asset to an int64 on 32-bit python
by supporting any Integral. We use a number of mappings keyed by
int64, which otherwise raise KeyErrors for Assets.
Also ensures
algo.current_sids()returns a list of Assets, instead of identifiers.For #650 and #926