Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution: Add helpers for querying task registry #348

Merged
merged 1 commit into from
Jul 30, 2018
Merged

Solution: Add helpers for querying task registry #348

merged 1 commit into from
Jul 30, 2018

Conversation

tomekowal
Copy link
Contributor

Closes: #344

This PR adds functions for querying task registry if specific task is running in the cluster or if any tasks are running.

I have a question about doctests. All documented functions with examples in TaskRegistry module have doctests disabled. I followed what is currently there and listed the two new functions in except. Shall I delete doctests for this module or do you want to have them enabled and listed all functions in except?

Thanks for your time reviewing the changes!

@coveralls
Copy link

coveralls commented Jul 30, 2018

Pull Request Test Coverage Report for Build 780

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 94.925%

Totals Coverage Status
Change from base Build 776: 0.1%
Covered Lines: 318
Relevant Lines: 335

💛 - Coveralls

@c-rack c-rack merged commit 8dd7bad into quantum-elixir:master Jul 30, 2018
@c-rack
Copy link
Member

c-rack commented Jul 30, 2018

Regarding doctests, maybe @maennchen could advise.

@maennchen
Copy link
Member

@tomekowal Thanks for your PR! I wanted to specifically disable doctests for functions that can't be properly tested because of state / side effects. The default should always be true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants