Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solution: Support manual job triggering #459

Merged
merged 3 commits into from Sep 25, 2020
Merged

Solution: Support manual job triggering #459

merged 3 commits into from Sep 25, 2020

Conversation

ericdude4
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Sep 24, 2020 •
edited

Pull Request Test Coverage Report for Build faf6522e08a590472301864f2c8be492c60db332-PR-459

  • 8 of 9 (88.89%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 87.24%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/quantum/job_broadcaster.ex 5 6 83.33%
Totals Coverage Status
Change from base Build 8f002322d85f6657d76154b3d34a84446f65ed3b: 0.04%
Covered Lines: 335
Relevant Lines: 384
💛 - Coveralls

maennchen
maennchen requested changes Sep 24, 2020
View reviewed changes
Copy link
Member

@maennchen maennchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR. There’s two small things that need some attention. I‘ll try it out in a project manually tomorrow.

mix.exs Outdated Show resolved Hide resolved
lib/quantum/job_broadcaster.ex Outdated Show resolved Hide resolved
@maennchen maennchen linked an issue Sep 24, 2020 that may be closed by this pull request
Trigger Jobs Manually #452
Closed
@maennchen maennchen self-assigned this Sep 24, 2020
@maennchen maennchen changed the title scheduler run_job functionality Solution: Support manual job triggering Sep 24, 2020
@maennchen maennchen merged commit fe0253a into quantum-elixir:master Sep 25, 2020
@maennchen
Copy link
Member

@ericdude4 Works great, I'll prepare a release :)

@maennchen
Copy link
Member

Released as v3.3.0

@pnezis pnezis mentioned this pull request Nov 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maennchen maennchen maennchen approved these changes

Assignees

@maennchen maennchen

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trigger Jobs Manually
3 participants
@ericdude4 @coveralls @maennchen