python lec10 about OOP #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stalkermustang
requested review from
Yorko,
nsmarkova,
SemyonSinchenko,
sharthZ23 and
vvssttkk
stalkermustang
commented
Aug 28, 2021
SemyonSinchenko
approved these changes
Aug 29, 2021
|
Мне нравится, круто! |
vvssttkk
reviewed
Aug 29, 2021
Co-authored-by: vtrokhymenko <8581044+vtrokhymenko@users.noreply.github.com>
vvssttkk
reviewed
Aug 29, 2021
| obj.energy += self.gamma * self.multiplier | ||
|
|
||
| class Object: | ||
| def __init__(self, energy = 10.0): |
There was a problem hiding this comment.
хорошо бы на все ф-и добавить типизацию, а то где-то они есть, а где-то напрочь отсутствуют, как и на возвращение функций
There was a problem hiding this comment.
я не стал добавлять везде чтобы не усложнять, так как там, например, есть пример ретерна такого же класса, то есть придется делать через строковый литерал, есть optional, придется объяснять что это итд. Думаешь, стоит добавить? Добавлял там, где менее очевидно и при этом не в нагрузку.
There was a problem hiding this comment.
хм.. палка о 2х концах. давай оставим как есть, а там посмотрим: мб дадим как дом. мат. о типизации
vvssttkk
reviewed
Aug 29, 2021
vvssttkk
reviewed
Aug 29, 2021
Co-authored-by: vtrokhymenko <8581044+vtrokhymenko@users.noreply.github.com>
vvssttkk
approved these changes
Aug 29, 2021
|
льем? |
SemyonSinchenko
approved these changes
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.