XDR-3403: Update Terraform's Azuread provider to 2.x #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hensonto
suggested changes
May 25, 2022
arledesma
previously requested changes
May 25, 2022
There was a problem hiding this comment.
With the variable names changing this is a breaking change.
Please amend the commit that changes the vars to include either (major) or (breaking) instead of (feat).
https://github.com/quantum-sec/meta/blob/master/standards/versioning/README.md#incrementing-versions
added 6 commits
May 26, 2022 12:12
The default value has also been changed.
GerardSetho
force-pushed
the
feature/XDR-3403
branch
from
07da8b4
to
399b142
Compare
arledesma
reviewed
May 27, 2022
Merely using uuid() would generate a new value each time we apply the resource. We can avoid this by generating a random_uuid resource per oauth2_permission_scopes.
hensonto
approved these changes
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 modules are upgraded to use azuread provider 2.22:
There wasn't any example code for azuread-service-principal, so we add that.
Many of the changes are simply
apiandwebblocks)However there are some more significant changes:
azuread-application: available_to_other_tenants
This argument
available_to_other_tenantsis changed tosign_in_audience. And while it was previously a boolean, it is now a string, with the following possible values:azuread-service-principal-password: password
We used to take in an optional input
password. Ifpasswordisn't specified, we would generate one (using therandom_passwordresource).From v 2.0 onwards, this is no longer possible. The password will be generated; it cannot be specified.