Skip to content

Commit

Permalink
[KED-1315] Add secret scan CircleCI step (#98)
Browse files Browse the repository at this point in the history
  • Loading branch information
Zain Patel committed Feb 10, 2020
1 parent c7a63a5 commit b0991d6
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 0 deletions.
6 changes: 6 additions & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,11 @@ utils:
command: |
make pylint
run_secret_scan: &run_secret_scan
name: Run secret scan
command: |
make secret-scan
run_python_tests: &run_python_tests
name: Run Python tests
command: make pytest
Expand Down Expand Up @@ -131,6 +136,7 @@ jobs:
- run: *run_javascript_tests
- run: *test_lib_transpilation
- run: *run_pylint_and_flake8
- run: *run_secret_scan
- run: *run_python_tests
- run: *run_e2e_tests
- run: *cleanup
Expand Down
3 changes: 3 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ pylint:
pylint -j 0 --disable=missing-docstring,no-name-in-module package/features
flake8 package

secret-scan:
trufflehog --max_depth 1 --exclude_path trufflehog-ignore.txt .

version:
python3 tools/versioning.py $(VERSION)

Expand Down
1 change: 1 addition & 0 deletions package/test_requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,4 @@ pytest-mock>=1.7.1,<2.0
requests-mock>=1.6.0, <2.0
flake8>=3.5, <4.0
isort
trufflehog>=2.0.99, <3.0
4 changes: 4 additions & 0 deletions trufflehog-ignore.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
package.json
package-lock.json
RELEASE.md
README.md

0 comments on commit b0991d6

Please sign in to comment.