Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BiQubitsMixer also can't decompose #389

Closed
fdmalone opened this issue Oct 9, 2023 · 5 comments · Fixed by quantumlib/Cirq#6313
Closed

BiQubitsMixer also can't decompose #389

fdmalone opened this issue Oct 9, 2023 · 5 comments · Fixed by quantumlib/Cirq#6313

Comments

@fdmalone
Copy link
Collaborator

fdmalone commented Oct 9, 2023

import cirq_ft
from qualtran.cirq_interop import CirqGateAsBloq
from qualtran.drawing import show_bloq

bloq = CirqGateAsBloq(cirq_ft.algos.BiQubitsMixer(False))
show_bloq(bloq.decompose_bloq())

BloqError: During finalization, {Soquet(binst=BloqInstance(bloq=Split(n=3), i=0), reg=Register(name='split', bitsize=1, shape=(3,), side=<Side.RIGHT: 2>), idx=(2,)), Soquet(binst=BloqInstance(bloq=Split(n=3), i=0), reg=Register(name='split', bitsize=1, shape=(3,), side=<Side.RIGHT: 2>), idx=(1,))} Soquets were not used.

@fdmalone
Copy link
Collaborator Author

fdmalone commented Oct 9, 2023

similar to #388

@fdmalone
Copy link
Collaborator Author

fdmalone commented Oct 9, 2023

I'll push a fix

@fdmalone
Copy link
Collaborator Author

Following discussion in quantumlib/Cirq#6613 I'm leaving this issue open to track the need for a better docstring / renaming of ancilla for the BiQubitsMixed cirq_ft gate which is used for the comparators.

@mpharrigan
Copy link
Collaborator

did you mean to close this?

@mpharrigan mpharrigan reopened this Oct 13, 2023
@fdmalone
Copy link
Collaborator Author

fdmalone commented Oct 13, 2023

Is there some auto close issue feature? Anyway it's fixed following #391

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants