Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature_scoring: Improve drop column log entry #261

Closed
EwoutH opened this issue Apr 20, 2023 · 0 comments · Fixed by #318
Closed

feature_scoring: Improve drop column log entry #261

EwoutH opened this issue Apr 20, 2023 · 0 comments · Fixed by #318
Assignees
@quaquel
Labels
docs

Comments

@EwoutH
Copy link
Collaborator

EwoutH commented Apr 20, 2023

I took a look at the source code but I'm still a bit confused about what's going on. Would it be possible to add some docstring for context and clarity? Also, it might be helpful to improve the print statement for better understanding.

EMAworkbench/ema_workbench/analysis/feature_scoring.py

Line 70 in 33bf8e9

("{} dropped from analysis " "because only a single category").format(column)

@EwoutH EwoutH added the docs label Apr 20, 2023
quaquel added a commit that referenced this issue Nov 20, 2023
@quaquel
change to log message and log level in feature scoring
1739302 
fixes #261

columns with the same value for all entries don't matter for feature scoring, so they can be ignored.
@quaquel quaquel mentioned this issue Nov 20, 2023
Merged
quaquel added a commit that referenced this issue Dec 1, 2023
@quaquel
change to log message and log level in feature scoring (#318)
2002532 
fixes #261

columns with the same value for all entries don't matter for feature scoring, so they can be ignored.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@quaquel quaquel

Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

change to log message and log level in feature scoring quaquel/EMAworkbench
2 participants
@quaquel @EwoutH