Improve code quality with static analysis #119

A lambda that calls a function without modifying any of its parameters is unnecessary. Python functions are first-class objects and can be passed around in the same way as the resulting lambda. It is recommended to remove the lambda and use the function directly. Example: hashify = lambda x: hash(x) It is preferred to use the function hash directly as the lambda function is calling the same function without any modifications. Another reason to avoid lambda function here is that it makes the debugging difficult. Lambdas show as <lambda> in tracebacks, where functions will display the function’s name.

It is unnecessary to use a comprehension just to loop over the iterable and create a list/set/dict out of it. Python has a specialized set of tools for this task: the list/set/dict constructors, which are faster and more readable.

Any method in a child class which is only calling the overridden method of any of its base class using super and doing nothing else is unnecessary. If the method isn't present in the child class, Python implicitly looks for the method in its base classes. This issue is valid only if the method in the child class and the method in the base class has the same signature.

To check if a variable is equal to one of many values, combine the values into a tuple and check if the variable is contained in it instead of checking for equality against each of the values. This is faster, less verbose, and more readable.

Iterate the dictionary directly instead of calling .keys(). Using for key in dictionary would always iterate the dictionary keys.

Instead of adding items to a dictionary just after creation, it should be refactored to add those items into the dict definition itself.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve code quality with static analysis #119

Improve code quality with static analysis #119

Commits on May 3, 2022