Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix permission analysis in the radare2 core for APKs with UTF-8 encoding #602

Conversation

zinwang
Copy link
Collaborator

@zinwang zinwang commented Jan 20, 2024

Refer to Issue #599 .

@zinwang zinwang self-assigned this Jan 20, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8e4d342) 78.67% compared to head (4912955) 78.74%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #602      +/-   ##
==========================================
+ Coverage   78.67%   78.74%   +0.06%     
==========================================
  Files          64       64              
  Lines        5309     5325      +16     
==========================================
+ Hits         4177     4193      +16     
  Misses       1132     1132              
Flag Coverage Δ
unittests 78.74% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@haeter525 haeter525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank @zinwang for this patch. @haeter525 approves.

@haeter525 haeter525 merged commit 5e47b0e into quark-engine:master Jan 20, 2024
13 checks passed
@zinwang zinwang deleted the fix_radare2_core_fail_to_analyze_apk_permission branch January 20, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quark cannot analyze pivaa.apk when using radare2 as the core library.
3 participants