feat: CloudWatch SDK #1151
Merged
feat: CloudWatch SDK #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amend docs description
scrocquesel
requested changes
Feb 28, 2024
There was a problem hiding this comment.
Awesome. Just a few remarks and you missed the dependency and reference from the docs/pom.xml (see
quarkus-amazon-services/docs/pom.xml
Line 129 in 65f5cff
pages in the included directory must be copied automatically by maven at the end of the build
Co-authored-by: Sébastien Crocquesel <88554524+scrocquesel@users.noreply.github.com>
Co-authored-by: Sébastien Crocquesel <88554524+scrocquesel@users.noreply.github.com>
Co-authored-by: Sébastien Crocquesel <88554524+scrocquesel@users.noreply.github.com>
|
Thanks for the review, I will adjust these tomorrow and do the same for #1154 |
|
Could you add a small integration test based on the quickstart to assert it works with LocalStack. |
|
Sure, let me do something by Monday |
scrocquesel
reviewed
Mar 10, 2024
...loyment/src/test/java/io/quarkus/amazon/cloudwatch/deployment/CloudWatchAsyncClientTest.java
Outdated
Show resolved
Hide resolved
scrocquesel
approved these changes
Mar 13, 2024
|
@all-contributors please add @andrezimmermann for code |
|
I've put up a pull request to add @andrezimmermann! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added the CloudWatch SDK, based of the SSM SDK scaffolding.
Over the documentation I just pretended that there is the cloudwatch quickstart and coded an HelloWorld example.
Work for #1150
On another note, I realized while coding the example that I actually wanted the CloudWatchLogs SDK, will be working on it if this PR is passable