Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix malformed metadata in extensions #116

Merged
merged 3 commits into from
Jun 14, 2023

Conversation

majguo
Copy link
Contributor

@majguo majguo commented Jun 12, 2023

After upgrading to quarkus 3.0, some errors are observed when running dev mode for integration-tests/azure-app-configuration and integration-tests/azure-storage-blob.

Error details:
2023-06-09 16:29:04,545 ERROR [io.qua.dev.dep.DevUIProcessor] (build-8) Failed to process extension descriptor file:///mnt/c/Users/jiangma/Workspace/repos/quarkus-azure-services/internal/jackson-dataformat-xml/runtime/target/classes/META-INF/quarkus-extension.yaml: java.lang.RuntimeException: Failed to locate 'artifact' or 'group-id' and 'artifact-id' among metadata keys [name, description, metadata]
        at io.quarkus.devui.deployment.DevUIProcessor.getExtensionNamespace(DevUIProcessor.java:709)
        at io.quarkus.devui.deployment.DevUIProcessor.lambda$getAllExtensions$1(DevUIProcessor.java:425)
        at io.quarkus.runtime.util.ClassPathUtils.lambda$consumeAsPath$0(ClassPathUtils.java:121)
        at io.quarkus.runtime.util.ClassPathUtils.processAsPath(ClassPathUtils.java:161)
        at io.quarkus.runtime.util.ClassPathUtils.consumeAsPath(ClassPathUtils.java:120)
        at io.quarkus.runtime.util.ClassPathUtils.consumeAsPaths(ClassPathUtils.java:104)
        at io.quarkus.runtime.util.ClassPathUtils.consumeAsPaths(ClassPathUtils.java:85)
        at io.quarkus.devui.deployment.DevUIProcessor.getAllExtensions(DevUIProcessor.java:409)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:566)
        at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:909)
        at io.quarkus.builder.BuildContext.run(BuildContext.java:282)
        at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)
        at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2513)
        at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1538)
        at java.base/java.lang.Thread.run(Thread.java:829)
        at org.jboss.threads.JBossThread.run(JBossThread.java:501)

2023-06-09 16:29:04,654 ERROR [io.qua.dev.dep.DevUIProcessor] (build-8) Failed to process extension descriptor file:///mnt/c/Users/jiangma/Workspace/repos/quarkus-azure-services/internal/core/runtime/target/classes/META-INF/quarkus-extension.yaml: java.lang.RuntimeException: Failed to locate 'artifact' or 'group-id' and 'artifact-id' among metadata keys [name, description, metadata]
        at io.quarkus.devui.deployment.DevUIProcessor.getExtensionNamespace(DevUIProcessor.java:709)
        at io.quarkus.devui.deployment.DevUIProcessor.lambda$getAllExtensions$1(DevUIProcessor.java:425)
        at io.quarkus.runtime.util.ClassPathUtils.lambda$consumeAsPath$0(ClassPathUtils.java:121)
        at io.quarkus.runtime.util.ClassPathUtils.processAsPath(ClassPathUtils.java:161)
        at io.quarkus.runtime.util.ClassPathUtils.consumeAsPath(ClassPathUtils.java:120)
        at io.quarkus.runtime.util.ClassPathUtils.consumeAsPaths(ClassPathUtils.java:104)
        at io.quarkus.runtime.util.ClassPathUtils.consumeAsPaths(ClassPathUtils.java:85)
        at io.quarkus.devui.deployment.DevUIProcessor.getAllExtensions(DevUIProcessor.java:409)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:566)
        at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:909)
        at io.quarkus.builder.BuildContext.run(BuildContext.java:282)
        at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)
        at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2513)
        at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1538)
        at java.base/java.lang.Thread.run(Thread.java:829)
        at org.jboss.threads.JBossThread.run(JBossThread.java:501)

2023-06-09 16:29:04,677 ERROR [io.qua.dev.dep.DevUIProcessor] (build-8) Failed to process extension descriptor file:///mnt/c/Users/jiangma/Workspace/repos/quarkus-azure-services/internal/http-client-vertx/runtime/target/classes/META-INF/quarkus-extension.yaml: java.lang.RuntimeException: Failed to locate 'artifact' or 'group-id' and 'artifact-id' among metadata keys [name, description, metadata]
        at io.quarkus.devui.deployment.DevUIProcessor.getExtensionNamespace(DevUIProcessor.java:709)
        at io.quarkus.devui.deployment.DevUIProcessor.lambda$getAllExtensions$1(DevUIProcessor.java:425)
        at io.quarkus.runtime.util.ClassPathUtils.lambda$consumeAsPath$0(ClassPathUtils.java:121)
        at io.quarkus.runtime.util.ClassPathUtils.processAsPath(ClassPathUtils.java:161)
        at io.quarkus.runtime.util.ClassPathUtils.consumeAsPath(ClassPathUtils.java:120)
        at io.quarkus.runtime.util.ClassPathUtils.consumeAsPaths(ClassPathUtils.java:104)
        at io.quarkus.runtime.util.ClassPathUtils.consumeAsPaths(ClassPathUtils.java:85)
        at io.quarkus.devui.deployment.DevUIProcessor.getAllExtensions(DevUIProcessor.java:409)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:566)
        at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:909)
        at io.quarkus.builder.BuildContext.run(BuildContext.java:282)
        at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)
        at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2513)
        at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1538)
        at java.base/java.lang.Thread.run(Thread.java:829)
        at org.jboss.threads.JBossThread.run(JBossThread.java:501)

2023-06-09 16:29:04,704 ERROR [io.qua.dev.dep.DevUIProcessor] (build-8) Failed to process extension descriptor file:///mnt/c/Users/jiangma/Workspace/repos/quarkus-azure-services/extensions/azure-storage-blob/runtime/target/classes/META-INF/quarkus-extension.yaml: java.lang.ClassCastException: class java.lang.String cannot be cast to class java.util.List (java.lang.String and java.util.List are in module java.base of loader 'bootstrap')
        at io.quarkus.devui.deployment.DevUIProcessor.lambda$getAllExtensions$1(DevUIProcessor.java:448)
        at io.quarkus.runtime.util.ClassPathUtils.lambda$consumeAsPath$0(ClassPathUtils.java:121)
        at io.quarkus.runtime.util.ClassPathUtils.processAsPath(ClassPathUtils.java:161)
        at io.quarkus.runtime.util.ClassPathUtils.consumeAsPath(ClassPathUtils.java:120)
        at io.quarkus.runtime.util.ClassPathUtils.consumeAsPaths(ClassPathUtils.java:104)
        at io.quarkus.runtime.util.ClassPathUtils.consumeAsPaths(ClassPathUtils.java:85)
        at io.quarkus.devui.deployment.DevUIProcessor.getAllExtensions(DevUIProcessor.java:409)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:566)
        at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:909)
        at io.quarkus.builder.BuildContext.run(BuildContext.java:282)
        at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)
        at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2513)
        at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1538)
        at java.base/java.lang.Thread.run(Thread.java:829)
        at org.jboss.threads.JBossThread.run(JBossThread.java:501)

2023-06-12 14:54:33,156 ERROR [io.qua.dev.dep.DevUIProcessor] (build-28) Failed to process extension descriptor file:///mnt/c/Users/jiangma/Workspace/repos/quarkus-azure-services/extensions/azure-app-configuration/runtime/target/classes/META-INF/quarkus-extension.yaml: java.lang.ClassCastException: class java.lang.String cannot be cast to class java.util.List (java.lang.String and java.util.List are in module java.base of loader 'bootstrap')
        at io.quarkus.devui.deployment.DevUIProcessor.lambda$getAllExtensions$1(DevUIProcessor.java:438)
        at io.quarkus.runtime.util.ClassPathUtils.lambda$consumeAsPath$0(ClassPathUtils.java:121)
        at io.quarkus.runtime.util.ClassPathUtils.processAsPath(ClassPathUtils.java:161)
        at io.quarkus.runtime.util.ClassPathUtils.consumeAsPath(ClassPathUtils.java:120)
        at io.quarkus.runtime.util.ClassPathUtils.consumeAsPaths(ClassPathUtils.java:104)
        at io.quarkus.runtime.util.ClassPathUtils.consumeAsPaths(ClassPathUtils.java:85)
        at io.quarkus.devui.deployment.DevUIProcessor.getAllExtensions(DevUIProcessor.java:399)
        at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
        at java.base/java.lang.reflect.Method.invoke(Method.java:578)
        at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:909)
        at io.quarkus.builder.BuildContext.run(BuildContext.java:282)
        at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)
        at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2513)
        at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1538)
        at java.base/java.lang.Thread.run(Thread.java:1589)
        at org.jboss.threads.JBossThread.run(JBossThread.java:501)

The PR is to resolve these errors by fixing malformed metadata in extensions, see references:

Signed-off-by: Jianguo Ma jiangma@microsoft.com

@majguo majguo temporarily deployed to ci June 12, 2023 06:52 — with GitHub Actions Inactive
@majguo majguo requested a review from backwind1233 June 12, 2023 10:50
@majguo majguo temporarily deployed to ci June 13, 2023 02:49 — with GitHub Actions Inactive
Copy link

@backwind1233 backwind1233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@majguo
Copy link
Contributor Author

majguo commented Jun 14, 2023

@all-contributors
please add @edburns for review.
please add @backwind1233 for review.

@allcontributors
Copy link
Contributor

@majguo

I've put up a pull request to add @edburns! 🎉

I've put up a pull request to add @backwind1233! 🎉

@majguo
Copy link
Contributor Author

majguo commented Jun 14, 2023

@all-contributors please add @backwind1233 for review.

@allcontributors
Copy link
Contributor

@majguo

@backwind1233 already contributed before to review

Signed-off-by: Jianguo Ma <jiangma@microsoft.com>
Signed-off-by: Jianguo Ma <jiangma@microsoft.com>
Signed-off-by: Jianguo Ma <jiangma@microsoft.com>
@majguo majguo temporarily deployed to ci June 14, 2023 02:49 — with GitHub Actions Inactive
@majguo majguo merged commit 79eb669 into quarkiverse:main Jun 14, 2023
1 check passed
@majguo majguo deleted the fix-quarkus-exte-yaml branch June 14, 2023 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants