Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace proxy runtime init code with "-H:+UseNewExperimentalClassInit… #937

Closed
wants to merge 2 commits into from

Conversation

shumonsharif
Copy link
Contributor

@shumonsharif shumonsharif commented Jul 6, 2023

…ialization"

@ppalaga I'm wondering if the -H:+UseNewExperimentalClassInitialization flag is a viable alternative to the Proxy runtime initialization workarounds we put in place. This approach also resolves all the cyclic issues identified in #860 and #916 .

EDIT: Looking closer through all the previous notes on Proxy runtime init, I just stumbled upon #580 (comment) where oracle/graal#4684 was already referenced. I guess I could've saved a couple hours of digging if I had read all of the notes carefully!!

I'm curious why you didn't go with this option, as it seems to be only a matter of time before this becomes the new default in Graal?

@dufoli
Copy link
Contributor

dufoli commented Jul 8, 2023

What is the stage of this graal feature ?

@shumonsharif
Copy link
Contributor Author

Hi @dufoli I'm not quite sure which stage this feature is in, or any specific timelines around it. Pretty much the only info I have is in the referenced graal issue.

It seems like a far simpler solution (even though the flag is experimental) to address the very unique edge case of proxy runtime initialization. I feel like we may be able to live with this flag until it becomes the Graal default - only because the list of extensions quarkus-cxf is currently incompatible with due to the cycle issues, seems to keep growing.

@shumonsharif
Copy link
Contributor Author

@ppalaga @dufoli
FYSA: https://groups.google.com/g/quarkus-dev/c/vGDPhln4qFw/m/Q02_FOASCAAJ

@dufoli
Copy link
Contributor

dufoli commented Jul 18, 2023

So I think it is a good signal to migrate on it right now and reduce loop bug

@andre-s-sousa
Copy link

Hey guys, any idea when this may get merged and released?
Sadly the loop bug is causing quite some issues that I have no solution for

@dufoli
Copy link
Contributor

dufoli commented Jul 20, 2023

@ppalaga what do you think about it ?

@dufoli dufoli requested a review from ppalaga July 20, 2023 11:38
@ppalaga
Copy link
Contributor

ppalaga commented Aug 15, 2023

I finally found time to start looking into this. Sorry for the delay.

@ppalaga
Copy link
Contributor

ppalaga commented Aug 15, 2023

I have commented in #860 (comment) and in accordance with that I am for closing the current PR in favor of #963

@ppalaga ppalaga closed this Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants