Merge pull request #594 from quarkiverse/default-memory-per-method

Segregate memory of concurrent requests to different AI services
quarkiverse · May 16, 2024 · 4975f10 · 4975f10
2 parents 9f82cf7 + aa95402
commit 4975f10
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/...va/io/quarkiverse/langchain4j/runtime/aiservice/AiServiceMethodImplementationSupport.java b/...va/io/quarkiverse/langchain4j/runtime/aiservice/AiServiceMethodImplementationSupport.java
@@ -346,7 +346,8 @@ private static Object memoryId(AiServiceMethodCreateInfo createInfo, Object[] me
             for (DefaultMemoryIdProvider provider : DEFAULT_MEMORY_ID_PROVIDERS) {
                 Object memoryId = provider.getMemoryId();
                 if (memoryId != null) {
-                    return memoryId;
+                    String perServiceSuffix = "#" + createInfo.getInterfaceName() + "." + createInfo.getMethodName();
+                    return memoryId + perServiceSuffix;
                 }
             }
         }

diff --git a/...ts/src/test/java/io/quarkiverse/langchain4j/websockets/next/tests/WebSocketsNextTest.java b/...ts/src/test/java/io/quarkiverse/langchain4j/websockets/next/tests/WebSocketsNextTest.java
@@ -32,7 +32,6 @@
 import io.quarkiverse.langchain4j.RegisterAiService;
 import io.quarkiverse.langchain4j.openai.testing.internal.OpenAiBaseTest;
 import io.quarkiverse.langchain4j.testing.internal.WiremockAware;
-import io.quarkus.arc.InjectableContext;
 import io.quarkus.test.QuarkusUnitTest;
 import io.quarkus.test.common.http.TestHTTPResource;
 import io.quarkus.websockets.next.OnOpen;
@@ -77,7 +76,7 @@ public void restRequest() {
                 .statusCode(200);
 
         assertThat(chatMemoryStore.idsFromGetMessages).hasSize(1)
-                .hasOnlyElementsOfType(InjectableContext.ContextState.class);
+                .hasOnlyElementsOfType(String.class);
         assertThat(chatMemoryStore.idsFromGetMessages).hasSameElementsAs(chatMemoryStore.idsFromDeleteMessaged);
 
         when()
@@ -86,7 +85,7 @@ public void restRequest() {
                 .statusCode(200);
 
         assertThat(chatMemoryStore.idsFromGetMessages).hasSize(2)
-                .hasOnlyElementsOfType(InjectableContext.ContextState.class);
+                .hasOnlyElementsOfType(String.class);
         assertThat(chatMemoryStore.idsFromGetMessages).hasSameElementsAs(chatMemoryStore.idsFromDeleteMessaged);
     }